From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id C2B2F3856947 for ; Wed, 10 May 2023 15:28:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C2B2F3856947 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 2B7E61003ECF3 for ; Wed, 10 May 2023 15:28:45 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id wlkDpfb0wZYqfwlkDpmcuF; Wed, 10 May 2023 15:28:45 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=fvEZ2H0f c=1 sm=1 tr=0 ts=645bb82d a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=P0xRbXHiH_UA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=75FAf6A6GYzAqeeAwkAA:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Wh6JEGYJoUaIU34zL0Bgd0g9VZmJ7hRr/X2geqvJmtY=; b=MUSK6UTLasOTZzhzj5HofPK31D tmBI55KWAnpkBRZChB8a2p01ADCHVV2tENXDEM3oGe1/p58sYQrO74Z4VbpyOtTyE5ERvo3ADLC5G tTTEFETWAyQQN7xAGe9SvVVM9; Received: from 71-211-191-82.hlrn.qwest.net ([71.211.191.82]:56452 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pwlkC-002BGQ-Q4; Wed, 10 May 2023 09:28:44 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries , Andrew Burgess Subject: Re: [PATCH] [gdb/tui] Fix tui compact-source a bit more References: <20230510132118.13761-1-tdevries@suse.de> X-Attribution: Tom Date: Wed, 10 May 2023 09:28:44 -0600 In-Reply-To: <20230510132118.13761-1-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Wed, 10 May 2023 15:21:18 +0200") Message-ID: <87h6sk5hoz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.191.82 X-Source-L: No X-Exim-ID: 1pwlkC-002BGQ-Q4 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-191-82.hlrn.qwest.net (murgatroyd) [71.211.191.82]:56452 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> To represent 11 we'd need 2 digits, so we expect to see ___04_ here instead of Tom> ___4_, even though all line numbers currently in the src window (3-9) can be Tom> represented with only 1 digit. Tom> Fix this in tui_source_window::set_contents, by updating the computation of Tom> max_line_nr: Tom> ... Tom> - int max_line_nr = std::max (lines_in_file, last_line_nr_in_window); Tom> + int max_line_nr = lines_in_file + nlines - 1; Tom> ... Makes sense to me. Approved-By: Tom Tromey Tom