From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id CD469385828E for ; Fri, 17 Feb 2023 22:29:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CD469385828E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676672984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=p00VR3HPCklsSBwma/uFcpvsNfY3udMc7Bcozt7khRk=; b=Eke5+iruUiIHuiMHeSIa4BTdbiiE+WlNL8dcX3RtVnJHOve/udmWNXmmk2BqklQoKiyfM3 w0gOawciWT8bcFPrXxH0g+2S3iGHH7oLA5tJjr8RE6COWZwfwRTmDXtf5DLAq170fbIisp gZG3MgyrlX054IV3tl6ZZtXojhzBEaI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-394-H70qlJp7PAe9xPK4Kn5KFw-1; Fri, 17 Feb 2023 17:29:43 -0500 X-MC-Unique: H70qlJp7PAe9xPK4Kn5KFw-1 Received: by mail-wm1-f70.google.com with SMTP id m18-20020a05600c3b1200b003dc5dec2ac6so1417251wms.4 for ; Fri, 17 Feb 2023 14:29:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=p00VR3HPCklsSBwma/uFcpvsNfY3udMc7Bcozt7khRk=; b=VNxpVUny7ej1xLxVrhHDd4TjVY4nv/UWLaWf0tWKvy4peZamUE+G94AsfB4GsdUm1m 7ARPeUjVZNuedC8a8+eCZpThr1svjpw8ThtzipfJXPYRpG6qIamWom8bkFRxdup5SBXv skS1Oc3GV0aQsERqZRUsCOUyliOPxn5G16xLjf68ShnimDqQMtvEQRnODsqSnmNqUxXd ZkofcAUZSF7nzxNY3UAXWuUa0N0GHoJXbrA7jqkd6BVv9qRo82kF6TrvR/QhA7gIdnvT +1O/DKY/BEPAiZuumG1Uz6kSwq8N9uyTf9fq5E6fJv3cm3mMH46OjGbv3Ft5RtixbG0z H1aQ== X-Gm-Message-State: AO0yUKWLuxBEtWPKSWgveghr4HV/u+NvzJc4oP7YOUGyDlS/jzjGt5xK rY/Sd469eAD6KyjMSkBBt6UMsJ2va1VzSkv9sIQQFiHx3wA+cxGgqP7Cy+67b2y6ICGS7p4zqtG 2y+7MX4+/Ki+Bc0ZRBnOpsIZhK7c= X-Received: by 2002:a05:600c:920:b0:3df:e6bb:768 with SMTP id m32-20020a05600c092000b003dfe6bb0768mr1499821wmp.24.1676672982140; Fri, 17 Feb 2023 14:29:42 -0800 (PST) X-Google-Smtp-Source: AK7set8Z5XxuaXP1AMMFEsckCujKgORlHyXqomF4rVCs+EAqWdaHbe5/waFbv4h6EApeNaI0Km+3+w== X-Received: by 2002:a05:600c:920:b0:3df:e6bb:768 with SMTP id m32-20020a05600c092000b003dfe6bb0768mr1499815wmp.24.1676672981848; Fri, 17 Feb 2023 14:29:41 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id bd27-20020a05600c1f1b00b003e20cf0408esm6472979wmb.40.2023.02.17.14.29.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 14:29:41 -0800 (PST) From: Andrew Burgess To: Tom Tromey Cc: Tom Tromey , Simon Marchi , Tom Tromey via Gdb-patches Subject: Re: [PATCH] Do not record a rejected target description In-Reply-To: <87pma8o031.fsf@tromey.com> References: <20230112193356.1133696-1-tromey@adacore.com> <87bklwmenh.fsf@redhat.com> <875yc4tawn.fsf@tromey.com> <875yc3m6in.fsf@redhat.com> <871qmqsyvu.fsf@tromey.com> <87zg9do1s6.fsf@tromey.com> <87o7pslhkz.fsf@redhat.com> <87pma8o031.fsf@tromey.com> Date: Fri, 17 Feb 2023 22:29:40 +0000 Message-ID: <87h6vkkjsb.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > >>> -# Required registers are not present so it is expected a warning. >>> -# >>> -gdb_test "set tdesc filename $srcdir/$subdir/maint_print_struct.xml" " >>> -warning:.*" "setting a new tdesc having only a structure" > > Andrew> Haven't you just deleted a test for a warning here? > > I thought it was just incidental. I looked at the history of the file > and the original commit message only discusses handling the "struct" > case. > > Andrew> I'd propose the patch below. > > Looks good to me, thanks. > Approved-By: Tom Tromey Pushed. Thanks, Andrew