From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id 8F6393858D35 for ; Wed, 15 Feb 2023 17:04:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8F6393858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id D37D310048296 for ; Wed, 15 Feb 2023 17:04:31 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id SLCppbxIVA1zNSLCppOOB9; Wed, 15 Feb 2023 17:04:31 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=CqN6zl0D c=1 sm=1 tr=0 ts=63ed109f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=IibqxDir5nvgAL-0K1oA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=WRfTGQygb6BjWIN+QM3FBtLpTL1w1PS5JmRAxy0sHZE=; b=iBKBEJlJYoa/yBFGuFrdwfS+gx fDXOaheT+0A6RrGT9fxvji3a58Tg7Cx69ElEv/KLBHLqObG625YTaE1TaJJLC8Eec+we/zh3YAx5M DM8od4oc1mPMTm0HkFXLQNc1a; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:35980 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pSLCp-004ECy-EO; Wed, 15 Feb 2023 10:04:31 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Tom Tromey , Simon Marchi , Simon Marchi Subject: Re: [PATCH] gdb: cast return value of std::unique_ptr::release to void References: <20230213195513.37532-1-simon.marchi@efficios.com> <87pmadcde1.fsf@tromey.com> <93c37005-30ec-f211-9e06-3a4896e134b2@simark.ca> X-Attribution: Tom Date: Wed, 15 Feb 2023 10:04:27 -0700 In-Reply-To: <93c37005-30ec-f211-9e06-3a4896e134b2@simark.ca> (Simon Marchi via Gdb-patches's message of "Tue, 14 Feb 2023 14:29:16 -0500") Message-ID: <87h6vmrhb8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pSLCp-004ECy-EO X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:35980 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon> I wanted to change cmd_list_element in the past to have "doc_holder" and Simon> "name_holder" fields, both of which would be Simon> gdb::unique_xmalloc_ptr. They would be set if the Simon> cmd_list_element owns the memory for doc and name, and would make the Simon> management automatic. But I'm afraid that people will say "but it makes Simon> cmd_list_element larger for nothing", so I never sent it. But if you Simon> think it's worth it, I can do that. I am not worried about the space savings here. It doesn't seem so bad to have a bit of manual management in this code, but at the same time, it wouldn't be a huge amount of memory, and if it makes things clearer, then it seems great. Stove-piping the unique ptr through all this code seems like a pain, though. I've sometimes wondered if we want a either-owns-or-is-constant-string smart pointer type. But it seems maybe hard to make this safe to use, as in it may be easy to construct one improperly. Tom