public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Make addrmap const-correct in cooked index
Date: Fri, 27 Jan 2023 14:15:24 -0700	[thread overview]
Message-ID: <87h6wbptlf.fsf@tromey.com> (raw)
In-Reply-To: <8446b53b-bd73-637b-7613-45c896d7240f@simark.ca> (Simon Marchi's message of "Fri, 27 Jan 2023 14:58:18 -0500")

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> I tried making the parameter to addrmap_foreach_fn const too (which
Simon> makes sense I think, if we're going to make foreach const), and came up
Simon> with a slightly larger patch.  It also made the find method return
Simon> const, but it also makes sense given that it is marked const too.
Simon> See the patch below, I think we can rebase yours on top of that.

Looks good to me.  Thank you.

>> -std::vector<addrmap *>
>> +std::vector<const addrmap *>
>> cooked_index_vector::get_addrmaps ()

Simon> You can make the get_addrmaps method const itself.

Will do.

Tom

  reply	other threads:[~2023-01-27 21:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27 16:26 Tom Tromey
2023-01-27 19:58 ` Simon Marchi
2023-01-27 21:15   ` Tom Tromey [this message]
2023-01-27 21:18   ` Tom Tromey
2023-01-27 21:20     ` Simon Marchi
2023-01-27 21:26       ` Simon Marchi
2023-01-30 14:15         ` Tom Tromey
2023-01-27 22:00     ` Simon Marchi
2023-01-30 14:26       ` Tom Tromey
2023-01-30 15:22         ` Simon Marchi
2023-01-30 15:29           ` [PATCH v2] " Simon Marchi
2023-01-30 16:54             ` Tom Tromey
2023-01-30 16:55               ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6wbptlf.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).