From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by sourceware.org (Postfix) with ESMTPS id A5E43385B501 for ; Fri, 27 Jan 2023 21:15:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A5E43385B501 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12e.google.com with SMTP id p12so2819842ilq.10 for ; Fri, 27 Jan 2023 13:15:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=GnA1UOvQnThDymTxCxKtkCj+CDCFfQ/uaAfMt8Rme0Y=; b=BVq4dRiSMQ3PPwp0NOAPSGNND/qa2eC6Ki+tkyqX9jisCC4JUHeMM5afyClBRE3tU1 fRD+qGzftpY1QlmxGYmaVBBY8bFXV6fr+YifSARb8fUE9pZMwHLxMlxYlq0uY8GQws1p 274HkJUjQiaJuTbEWeQv9J68BRMbxCLlpREJadwPXQAHPSwME7Xu2HOgM7G73YWtR6Bo x8F84tWoF9+E34dl6JFEakTzlb24aH9fO6ta986kshFUXomQjRM1Od6hl1D/4UwKueG2 QUHA2tFtGjMcNYih7fhVBRV9JfJHcdQEIKhkI9XTMN3TVxVk1m3Yb9NQjISMhbLLHHCP GeQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GnA1UOvQnThDymTxCxKtkCj+CDCFfQ/uaAfMt8Rme0Y=; b=2UeD7W8a/MveSgq1RVsn7Hj4jwVy7S2/MqqBpH+pdSiannVxUOmbQNRyzQ/I1llWP8 jaNXKBBW2wT96zKp33GgTakert6LEO8fXn+KOsdGUR5bGf/5DLn3C+H1b3Pt8gRLlkKi u1dpZxODaueBE9AJmrTq08viDNDulEa8Dub8N0BcmmH44gXINPeq7HEKDZCdNxKGEx4f xGykF//STjnm9nQV59+lnA9tf+QUcIfqbb5NRUnqqVZGCzPeNpJcPP7zztuZ8QooKF8S 3QB0AlZZblFY4glJr6FBO0VuTiQNr5cPB7Gyer3KixsRCYTMSjhvAPypPhoPNfE1u4pW AUAg== X-Gm-Message-State: AO0yUKWsKaHbcX1kVtDTBIWZSkDrfrYDWyI4KrBKKtdLwKVxFut0ePG/ e1Hu5JbFHvKAOFeRE/EaBtDFSw== X-Google-Smtp-Source: AK7set/lXwvfVJqKDzJDFXtNbulShs32S6BB1WTPMFlF5nClYtIrdwP85NDx3voylhQMXY1ggFWcIg== X-Received: by 2002:a05:6e02:1c2f:b0:310:a5b8:5049 with SMTP id m15-20020a056e021c2f00b00310a5b85049mr81845ilh.5.1674854125955; Fri, 27 Jan 2023 13:15:25 -0800 (PST) Received: from murgatroyd (75-166-146-144.hlrn.qwest.net. [75.166.146.144]) by smtp.gmail.com with ESMTPSA id c17-20020a02a411000000b00363362cd476sm1885936jal.101.2023.01.27.13.15.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 13:15:25 -0800 (PST) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Make addrmap const-correct in cooked index References: <20230127162603.4127820-1-tromey@adacore.com> <8446b53b-bd73-637b-7613-45c896d7240f@simark.ca> X-Attribution: Tom Date: Fri, 27 Jan 2023 14:15:24 -0700 In-Reply-To: <8446b53b-bd73-637b-7613-45c896d7240f@simark.ca> (Simon Marchi's message of "Fri, 27 Jan 2023 14:58:18 -0500") Message-ID: <87h6wbptlf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: Simon> I tried making the parameter to addrmap_foreach_fn const too (which Simon> makes sense I think, if we're going to make foreach const), and came up Simon> with a slightly larger patch. It also made the find method return Simon> const, but it also makes sense given that it is marked const too. Simon> See the patch below, I think we can rebase yours on top of that. Looks good to me. Thank you. >> -std::vector >> +std::vector >> cooked_index_vector::get_addrmaps () Simon> You can make the get_addrmaps method const itself. Will do. Tom