From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id 4F4F23897A00 for ; Thu, 15 Dec 2022 21:27:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4F4F23897A00 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 2149E10048EA6 for ; Thu, 15 Dec 2022 21:27:40 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 5vlUpyyHhXEB25vlUp7WVF; Thu, 15 Dec 2022 21:27:40 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Ab50o1bG c=1 sm=1 tr=0 ts=639b914c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=sHyYjHe8cH0A:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=qPDIdC0WzUxaSgDjCTIA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2CsHF+RahmTs7CM4/3rxeOIxbrPp2oJaO1pavRDdYgc=; b=QF9gZ7XXTuYkBFXKVWN04RK8IK JZ9MDAGFFBIMTc2iJ5k6RKqwD2kEsAvM5YKwlZeX0oAlVnIh6gJzmDJ+e1wqRzS2u8MRmNX+iMCxh bREvdfbcErCG4dZoEAZOZbFT6; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56992 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p5vlT-000jqp-RY; Thu, 15 Dec 2022 14:27:39 -0700 From: Tom Tromey To: Lancelot SIX via Gdb-patches Cc: Bruno Larsen , Lancelot SIX Subject: Re: [PATCH] gdb: add 'maintenance print record-instruction' command References: <20221207135000.1344331-1-blarsen@redhat.com> <20221207143731.uopir7l4ilssjkqv@ubuntu.lan> X-Attribution: Tom Date: Thu, 15 Dec 2022 14:27:37 -0700 In-Reply-To: <20221207143731.uopir7l4ilssjkqv@ubuntu.lan> (Lancelot SIX via Gdb-patches's message of "Wed, 7 Dec 2022 14:37:31 +0000") Message-ID: <87h6xwcq7q.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1p5vlT-000jqp-RY X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56992 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Lancelot" == Lancelot SIX via Gdb-patches writes: >> +static void >> +maintenance_print_record_instruction (const char *args, int from_tty) Lancelot> I think, usually the command implementation have a _command suffix in Lancelot> the name. I do not know if this is a hard rule. Historically there were a couple of conventions like this, but IMO as long as the command implementation has the command name in it, then that is great -- it makes it easy to find it via tags. Tom