From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id CBD393894C37 for ; Mon, 5 Dec 2022 20:59:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CBD393894C37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 2B7A010047D8C for ; Mon, 5 Dec 2022 20:59:46 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 2IZ0p3PQVaecb2IZ0pTuiu; Mon, 05 Dec 2022 20:59:46 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Lq9XdlRc c=1 sm=1 tr=0 ts=638e5bc2 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=sHyYjHe8cH0A:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=cSccdjhALEkDv-_A5DMA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=IFlP1mazds+fyB5zfgPwVDbLmFHu/wGxgZzYOs4GyHU=; b=SWohwls7TDTS9JuRIAgrtWEQ93 k41XFKa7z6PuIiuNc0688JPizogofiHd3MKt7CS46vzJ/7/xEG5DU6Iy+AH3ueQ0+OZwTxoNQ3o93 OYfOHmS+w/FEpaw57dKLVQ5ea; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56934 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p2IYz-0031Dt-UK; Mon, 05 Dec 2022 13:59:45 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH] gdb/testsuite: remove perror calls when failing to run References: <20221129213931.108445-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Mon, 05 Dec 2022 13:59:44 -0700 In-Reply-To: <20221129213931.108445-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Tue, 29 Nov 2022 16:39:31 -0500") Message-ID: <87h6y9k1mn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1p2IYz-0031Dt-UK X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56934 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> The problem is that arrayptr.exp calls perror when failing to run to Simon> main, then returns. perror makes it so that the next test (as in Simon> pass/fail) will be recorded as UNRESOLVED. However, here, the next test Simon> (as in pass/fail) is in the next test (as in .exp). Hence the spurious Simon> UNRESOLVED in assign_1.exp. Simon> These perror when failing to run to X are not really useful, especially Simon> since runto records a FAIL on error, by default. Remove all the Simon> perrors on runto failure I could find. Thanks for doing this. I didn't read the patch, but the idea seems sensible to me. >From the dejagnu description of perror, I wonder if the gdb test suite should ever call it: Declares a severe error in the testing framework itself. Simon> I thought of adding a check ran between test (in gdb_finish Simon> probably) where we would emit a warning if errcnt > 0, meaning a test Simon> quit and left a perror "active". However, reading that variable would Simon> poke into the DejaGNU internals, not sure it's a good idea. Perhaps dejagnu itself should be doing this. Tom