From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 298E43858CDA for ; Thu, 1 Dec 2022 15:16:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 298E43858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669907809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yJD8OY/HsMVK8GItcint3gBlVZ1NyqVeBH0bzNRB6qA=; b=huGCsGvUko1eYTFBepaouTEtcZDD/CjDHHK84KIsjK/IjjUj+PuF2ZYZMqK/+A04TLtqKy l+DFTuS9hqdHJiMx2J8e/9HuAd0KU2zLBluqS+1ecRisw2zpwpltUjRxcj4NVNEZNM/l3G ieKpq1sVAfxJXw0SBTfxXOD2de7+nto= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-9-cBCS_VDjPXKr1FRvRwLULQ-1; Thu, 01 Dec 2022 10:16:44 -0500 X-MC-Unique: cBCS_VDjPXKr1FRvRwLULQ-1 Received: by mail-wr1-f71.google.com with SMTP id g14-20020adfa48e000000b00241f94bcd54so513526wrb.23 for ; Thu, 01 Dec 2022 07:16:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yJD8OY/HsMVK8GItcint3gBlVZ1NyqVeBH0bzNRB6qA=; b=352orwiayWfzCl9kVjlRGs/wRyHbXfNkWhOqjOO0azreaFZou2rFw2CgIIfvvs9hUK zBozaDOYXknX6UE4Nw1JdYIUqou/GnJTx5mR+lm4k5ozKkRq8PZ8NCC5cjFf+yUTxKBQ bkIprdW9EWSB8VR5D5J0bthG5foLB1vuUwtUh//iJbe0lT7GFpVeD6ZDIFcGFJvTvRJs zB5p6JehAd2KyEYf5IF8crk0juO4Y+Ra0KgEnaUsvDjvP8Nu9dUr1iV04qoenq12+Kqh fe9tE7d+pAGB5CgNQ+K0EKicwMegOOpFpVm+s1rWwO4w6UHEY2ocZdCOa1UdVk7sga6W F+WQ== X-Gm-Message-State: ANoB5pmO+QHpRL87icMlQ8akbhq2RYd5AVJYRjom7VpiYnenGXQS/omI Puu7lbFKLVg5weg1q/SBeiizWaYu3tYoFLX09HXUMs+CCLSyEs2Gzx/mRtfhnABw623HPmkzLiL chhSdmqfllb3Cb5bZnIGuklwsCEGoi2hDqjn8c+PiO7ln3+wUs4fAHTLZafpFRP2oM+O7qZx4TA == X-Received: by 2002:a05:600c:1c92:b0:3cf:88cf:1f8e with SMTP id k18-20020a05600c1c9200b003cf88cf1f8emr40051559wms.9.1669907803059; Thu, 01 Dec 2022 07:16:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf5fOJxFHTZvSH1/AC0+s8OQaZBxM5onx1tWw1GcS/hDbpraq4VsE6AwPdTXF1ihAmw7YqecAw== X-Received: by 2002:a05:600c:1c92:b0:3cf:88cf:1f8e with SMTP id k18-20020a05600c1c9200b003cf88cf1f8emr40051534wms.9.1669907802766; Thu, 01 Dec 2022 07:16:42 -0800 (PST) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id k10-20020a056000004a00b002365730eae8sm4691189wrx.55.2022.12.01.07.16.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 07:16:42 -0800 (PST) From: Andrew Burgess To: Tom Tromey via Gdb-patches , gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [PATCH 1/3] Remove language check from dwarf2_compute_name In-Reply-To: <20221107162356.3175221-2-tromey@adacore.com> References: <20221107162356.3175221-1-tromey@adacore.com> <20221107162356.3175221-2-tromey@adacore.com> Date: Thu, 01 Dec 2022 15:16:41 +0000 Message-ID: <87h6yf17dy.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey via Gdb-patches writes: > dwarf2_compute_name has a redundant check of the CU's language -- this > is also checked in dwarf2_canonicalize_name. Removing this slightly > simplifies a future patch. LGTM. Thanks, Andrew > --- > gdb/dwarf2/read.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c > index 60e120a9d76..978dd4d0bb9 100644 > --- a/gdb/dwarf2/read.c > +++ b/gdb/dwarf2/read.c > @@ -8918,7 +8918,6 @@ dwarf2_compute_name (const char *name, > if (die_needs_namespace (die, cu)) > { > const char *prefix; > - const char *canonical_name = NULL; > > string_file buf; > > @@ -9084,10 +9083,9 @@ dwarf2_compute_name (const char *name, > > const std::string &intermediate_name = buf.string (); > > - if (lang == language_cplus) > - canonical_name > - = dwarf2_canonicalize_name (intermediate_name.c_str (), cu, > - objfile); > + const char *canonical_name > + = dwarf2_canonicalize_name (intermediate_name.c_str (), cu, > + objfile); > > /* If we only computed INTERMEDIATE_NAME, or if > INTERMEDIATE_NAME is already canonical, then we need to > -- > 2.34.3