From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id DFEE5384F6EA for ; Fri, 18 Nov 2022 11:28:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DFEE5384F6EA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668770884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6BJzHZ5gO59AAePN2ZOpT2oZmo+kKg2WGyqQnhj4Dag=; b=KVWJ8CBgm9B8SLuUwAYYtd6RK/efgXAPYodtz7LbgNycH+u6D0IJLMPEwXKX/j3RhtX6nK Wimgba8x0JuxAubEZvbuGTdODyFY9smtuGdyCsacg00z23XgGVzz7+URV9qmZNWt07JwfW uT8hmjng7ydldj6NJhrW3kZQZ6xXaqo= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-470-hltHJ1X7O4iD7VrCIvIH6Q-1; Fri, 18 Nov 2022 06:28:03 -0500 X-MC-Unique: hltHJ1X7O4iD7VrCIvIH6Q-1 Received: by mail-wr1-f69.google.com with SMTP id t12-20020adfa2cc000000b0022adcbb248bso1445486wra.1 for ; Fri, 18 Nov 2022 03:28:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6BJzHZ5gO59AAePN2ZOpT2oZmo+kKg2WGyqQnhj4Dag=; b=LJ1ZHG43FDzCMj4xGl2+doRH6gb7d6nYGT9IES6TNMcKO/WK6Z3l0nBz0SD7ruDVID okEFEZDDpDqt9LhbjOIMpjh3uPk26IoO/eEU8eYUrlBYJ9OqCi48La47LQ60bb1bTMRF PKDtCDOYvtK6kiln0kDFguUj0VMIEpT0GYyqpplNIP+x9lgU+Li/ZGFDJ4cSxcHaE5SM Z3CCAsRIcrbJ7+MV9mLj7p1++3P2a+C+hL3SgEChidW/3Ba1D633LE20MkvFR9gG9zPM /LA4XHOohzCgH+KjE8jc17+nutl65XXTXhXxk3ep1ErA5KUROFgmw2NPHHsPlzVp/mKX WgiA== X-Gm-Message-State: ANoB5plKAcCqWJWxi4i1KQmQeopeH9402iBmkGoEI7sN5n1VtGVHBX/H QZDUOb47OsnhZpafTFnnsyT+Y9ityePhQyn5m/3dG9xcwppMAlXr+Q1Wr1okjRF6ffrBV7ugor9 b8Li3K4PgzLL7Vepc9x7+NdsgyKtMKqT/YnvPpBU/fBazJs8++xRnSHF5bQSaUURHOsApmUENLA == X-Received: by 2002:a05:600c:5118:b0:3cf:8e70:f34f with SMTP id o24-20020a05600c511800b003cf8e70f34fmr4445085wms.93.1668770882026; Fri, 18 Nov 2022 03:28:02 -0800 (PST) X-Google-Smtp-Source: AA0mqf67UdxyHeXY/i6on/V0p17Ip/gdpVTEQyE3F1F1kasT5XUp+iLDcys/3XyUDIfPBoVXSGpQHA== X-Received: by 2002:a05:600c:5118:b0:3cf:8e70:f34f with SMTP id o24-20020a05600c511800b003cf8e70f34fmr4445065wms.93.1668770881676; Fri, 18 Nov 2022 03:28:01 -0800 (PST) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id o18-20020a05600c4fd200b003cfa26c410asm9675554wmq.20.2022.11.18.03.28.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 03:28:01 -0800 (PST) From: Andrew Burgess To: Simon Marchi via Gdb-patches , gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 4/8] gdbserver/linux: take condition out of callback in find_lwp_pid In-Reply-To: <20221117194241.1776125-5-simon.marchi@efficios.com> References: <20221117194241.1776125-1-simon.marchi@efficios.com> <20221117194241.1776125-5-simon.marchi@efficios.com> Date: Fri, 18 Nov 2022 11:28:00 +0000 Message-ID: <87h6yw8ptr.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon Marchi via Gdb-patches writes: > Just a small optimization, it's not necessary to recompute lwp at each > iteration. > > While at it, change the variable type to long, as ptid_t::lwp returns a > long. > > Change-Id: I181670ce1f90b59cb09ea4899367750be2ad9105 LGTM. Reviewed-By: Andrew Burgess Thanks, Andrew > --- > gdbserver/linux-low.cc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc > index 0cbfeb99086..a896b37528b 100644 > --- a/gdbserver/linux-low.cc > +++ b/gdbserver/linux-low.cc > @@ -1731,9 +1731,9 @@ linux_process_target::status_pending_p_callback (thread_info *thread, > struct lwp_info * > find_lwp_pid (ptid_t ptid) > { > - thread_info *thread = find_thread ([&] (thread_info *thr_arg) > + long lwp = ptid.lwp () != 0 ? ptid.lwp () : ptid.pid (); > + thread_info *thread = find_thread ([lwp] (thread_info *thr_arg) > { > - int lwp = ptid.lwp () != 0 ? ptid.lwp () : ptid.pid (); > return thr_arg->id.lwp () == lwp; > }); > > -- > 2.37.3