From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id D7A833852C4D for ; Thu, 17 Nov 2022 19:29:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D7A833852C4D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id E1F4C100425E9 for ; Thu, 17 Nov 2022 19:29:35 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id vkZroraPYjKFBvkZro7lLj; Thu, 17 Nov 2022 19:29:35 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=QtabYX+d c=1 sm=1 tr=0 ts=63768b9f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=9xFQ1JgjjksA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=9ZZymTJL3pgLcqafwmgA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=W2HO13jJi6c+fAjsANyVOzIlOCXA4WS+Jw/qCjjFtfM=; b=PXtpak5I8j2V4aTA+1eN6SZjeF AaJi5PhAmnpZG2pQ+33fUFe0NKjAIZsnB+RmGefPGRfblVgEUkefPiHCuFb9pCex/U7dWRCcyr4br xcjqsCMQ27I86EKm9SgXqXm4E; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56862 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ovkZr-002tWr-Dc; Thu, 17 Nov 2022 12:29:35 -0700 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess , Tom Tromey Subject: Re: [PATCHv2 0/2] Fix gdb.debuginfod/fetch_src_and_symbols.exp with Clang References: <87wn7uuakv.fsf@tromey.com> X-Attribution: Tom Date: Thu, 17 Nov 2022 12:29:32 -0700 In-Reply-To: (Andrew Burgess via Gdb-patches's message of "Thu, 17 Nov 2022 11:38:04 +0000") Message-ID: <87h6yxs7kz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1ovkZr-002tWr-Dc X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56862 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Andrew> Thanks for the feedback. I've updated the test inline with your suggestion. Andrew> While making this change I wondered if there was any reason why the Andrew> source file for this test is called 'main.c' rather than the expected Andrew> fetch_src_and_symbols.c. I couldn't see any reason, so in the first Andrew> patch below I rename the source file, then the second patch below is Andrew> an improved version of my v1 patch. These look good to me. Thank you. Tom