From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 94E8B3853823 for ; Fri, 21 Oct 2022 15:30:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 94E8B3853823 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id 9BCAF10045325 for ; Fri, 21 Oct 2022 15:30:11 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id ltyMogTqoQOZjltyNoZR7v; Fri, 21 Oct 2022 15:30:11 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=CvV6zl0D c=1 sm=1 tr=0 ts=6352bb03 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=Qawa6l4ZSaYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=oYB8Y1FGIqhQd04uoVIA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=dYdbPSCUilmB3QbprsprZihhGXoqJC0Pog8QFT5gW8s=; b=f6pO5d8qItsjjkLz7tuogWIcBU feYBsoACGecZu33qTBZqI8mDItQ4+qdZDA6GEV5O3tTtJX3uE0L7VTFbQ782K4dOjze0vQdLTxX7k k4jI/GyLpwWvh7fHOl7sPalaG; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56736 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oltyM-001xjd-Bi; Fri, 21 Oct 2022 09:30:10 -0600 From: Tom Tromey To: Markus Metzger via Gdb-patches Subject: Re: [PATCH] gdb, btrace: fix family and model computation References: <20221021121308.294059-1-markus.t.metzger@intel.com> X-Attribution: Tom Date: Fri, 21 Oct 2022 09:30:07 -0600 In-Reply-To: <20221021121308.294059-1-markus.t.metzger@intel.com> (Markus Metzger via Gdb-patches's message of "Fri, 21 Oct 2022 14:13:08 +0200") Message-ID: <87h6zxchz4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1oltyM-001xjd-Bi X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56736 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2022 15:38:09 -0000 >>>>> "Markus" == Markus Metzger via Gdb-patches writes: Markus> In gdb/nat/linux-btrace.c:btrace_this_cpu() we initialize the cpu Markus> structure given to the libipt btrace decoder. Markus> We only consider the extended model field for family 0x6 and forget about Markus> family 0xf and we don't consider the extended family field. Fix it. You should probably just self-approve this. Markus> cpu.family = (cpuid >> 8) & 0xf; Markus> - cpu.model = (cpuid >> 4) & 0xf; Markus> + if (cpu.family == 0xf) Markus> + cpu.family += (cpuid >> 20) & 0xff; Markus> - if (cpu.family == 0x6) Markus> + cpu.model = (cpuid >> 4) & 0xf; Markus> + if ((cpu.family == 0x6) || ((cpu.family & 0xf) == 0xf)) Markus> cpu.model += (cpuid >> 12) & 0xf0; I wonder if these magic numbers have #defines anywhere we could use. Tom