From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 826ED3858422 for ; Thu, 22 Sep 2022 09:43:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 826ED3858422 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-451-0DQ-YOBBML6w9Nq3fgryDA-1; Thu, 22 Sep 2022 05:43:02 -0400 X-MC-Unique: 0DQ-YOBBML6w9Nq3fgryDA-1 Received: by mail-wm1-f69.google.com with SMTP id 7-20020a05600c020700b003b4ce6e6b12so555932wmi.0 for ; Thu, 22 Sep 2022 02:43:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date; bh=29iPV7/332H9wl+h284eGSK8jOuJ4xhzFA46k/hDUwo=; b=XAlqSldd1NALJb858pY9EeGOmdwVitucvdyLbVCL9/TKerozVyrS+XtK5PcQ9pOsbG iHfeZqCwLJ3dHitJ0CqwOCBNCxGVNUxupBeReeN5Na487seXybAVsXYp1/5lTS2PRxAw D8pT3dL8ejug0Q5Trz6qrssC7AXIbravb7Ps2Z0gVjNcLdDqKC4m6KQ7kYxVx+6KwldW YyqgG6errxAGz1CMoUCpj8aoFHr2VsXnNA+blLlB6B9qeysJHfvJUm57vsJC+KHvq8+5 ApjyXndstb54Rolrh7R+yl19u7HUhIIFq9z27i6hEoQrufUOmx1WxlOhac9KvFBVhjf6 S6VA== X-Gm-Message-State: ACrzQf0cV7X+jrLX1l7tFcPq77tbj8Q2qCiwjw2lOijZGgBiccpW8xJo pWoWvRaxQ5VQrlvlQWqwgBCkRQGteCMbWoR7EIPx50/r7vyUEkkxVk4KkHafdo2bRKUW+DKuVQ4 6Z30OW9GewoV5j4zFgcnCHw== X-Received: by 2002:adf:f345:0:b0:22a:e304:bd3c with SMTP id e5-20020adff345000000b0022ae304bd3cmr1458244wrp.515.1663839780915; Thu, 22 Sep 2022 02:43:00 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4qLIILJsAoLD1D/0rODjBKBC70ik/NGCQ486DY+eEPfdSbw8fFEEI35wG6ERNr0M7ET4lAig== X-Received: by 2002:adf:f345:0:b0:22a:e304:bd3c with SMTP id e5-20020adff345000000b0022ae304bd3cmr1458230wrp.515.1663839780655; Thu, 22 Sep 2022 02:43:00 -0700 (PDT) Received: from localhost (52.72.115.87.dyn.plus.net. [87.115.72.52]) by smtp.gmail.com with ESMTPSA id bn27-20020a056000061b00b0022762b0e2a2sm5169892wrb.6.2022.09.22.02.43.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Sep 2022 02:43:00 -0700 (PDT) From: Andrew Burgess To: Tom Tromey , Andrew Burgess via Gdb-patches Subject: Re: [PATCH] gdb/python: restrict the names accepted by gdb.register_window_type In-Reply-To: <87wn9w4wm3.fsf@tromey.com> References: <20220914142904.1071745-1-aburgess@redhat.com> <87wn9w4wm3.fsf@tromey.com> Date: Thu, 22 Sep 2022 10:42:59 +0100 Message-ID: <87h70zeod8.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2022 09:43:06 -0000 Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: > > Andrew> In the end I figured it might make sense to place some restrictive > Andrew> rules in place, and then relax the rules later if/when users complain, > Andrew> we can consider each relaxation as its requested. > > Andrew> So, I propose that window names should match this regular expression: > > Andrew> [a-zA-Z][-_.a-zA-Z0-9]* > > Makes sense to me. > > Andrew> There is a chance that there is user code in the wild which will break > Andrew> with the addition of this change, but hopefully adapting to the new > Andrew> restrictions shouldn't be too difficult. > > It's possible but I wouldn't worry about it. > > This patch looks good to me. Thanks, pushed. Andrew