From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 6/9] gdb: add asserts to gdbarch_register_name
Date: Wed, 21 Sep 2022 12:04:28 -0600 [thread overview]
Message-ID: <87h71038pf.fsf@tromey.com> (raw)
In-Reply-To: <a688d3942d63b4f5a21f38bbd44852b82f214ce1.1662067442.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Thu, 1 Sep 2022 22:31:14 +0100")
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
Andrew> diff --git a/gdb/gdbarch.py b/gdb/gdbarch.py
Andrew> index 696b3028e6f..699ed4f69d2 100755
Andrew> --- a/gdb/gdbarch.py
Andrew> +++ b/gdb/gdbarch.py
Andrew> @@ -112,6 +112,8 @@ class Function(_Component):
Andrew> postdefault=None,
Andrew> invalid=None,
Andrew> printer=None,
Andrew> + param_checks=None,
Andrew> + result_checks=None,
Andrew> ):
Andrew> super().__init__(
Andrew> comment=comment,
Andrew> @@ -124,6 +126,11 @@ class Function(_Component):
Andrew> printer=printer,
Andrew> params=params,
Andrew> )
Andrew> + self.param_checks = param_checks
Andrew> + self.result_checks = result_checks
It's fine to just pass these to the superclass constructor.
That will ensure they end up as attributes of 'self', without needing
separate assignments.
Tom
next prev parent reply other threads:[~2022-09-21 18:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 21:31 [PATCH 0/9] Lots of changes to gdbarch_register_name (many architectures) Andrew Burgess
2022-09-01 21:31 ` [PATCH 1/9] gdb/testsuite: rewrite capture_command_output proc Andrew Burgess
2022-09-01 21:31 ` [PATCH 2/9] gdb/riscv: fix failure in gdb.base/completion.exp Andrew Burgess
2022-09-01 21:31 ` [PATCH 3/9] gdb/gdbarch: add a comment to gdbarch_register_name Andrew Burgess
2022-09-01 21:31 ` [PATCH 4/9] gdb: add a gdbarch_register_name self test, and fix some architectures Andrew Burgess
2022-09-01 21:31 ` [PATCH 5/9] gdb: check for duplicate register names in selftest Andrew Burgess
2022-09-01 21:31 ` [PATCH 6/9] gdb: add asserts to gdbarch_register_name Andrew Burgess
2022-09-21 18:04 ` Tom Tromey [this message]
2022-09-01 21:31 ` [PATCH 7/9] gdb/csky: remove nullptr return from csky_pseudo_register_name Andrew Burgess
2022-09-01 21:31 ` [PATCH 8/9] gdb: final cleanup of various gdbarch_register_name methods Andrew Burgess
2022-09-01 21:31 ` [PATCH 9/9] gdb: update now gdbarch_register_name doesn't return nullptr Andrew Burgess
2022-09-21 18:07 ` [PATCH 0/9] Lots of changes to gdbarch_register_name (many architectures) Tom Tromey
2022-10-02 16:28 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h71038pf.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).