From: Tom Tromey <tom@tromey.com>
To: Bruno Larsen <blarsen@redhat.com>
Cc: gdb-patches@sourceware.org, tom@tromey.com
Subject: Re: [PATCH v2 2/4] Introduce frame_info_ptr smart pointer class
Date: Fri, 08 Jul 2022 21:26:00 -0600 [thread overview]
Message-ID: <87h73rt19z.fsf@tromey.com> (raw)
In-Reply-To: <20220708160741.4122837-3-blarsen@redhat.com> (Bruno Larsen's message of "Fri, 8 Jul 2022 13:07:39 -0300")
>>>>> "Bruno" == Bruno Larsen <blarsen@redhat.com> writes:
Bruno> + /* The underlying pointer. */
Bruno> + frame_info *m_ptr;
Bruno> + /* Point to next and previous items in the circular list. */
Bruno> + frame_info_ptr *m_next;
Bruno> + frame_info_ptr *m_prev;
The reason I didn't resubmit this is that there was a request to make
this use some pre-existing template class, and my attempts to do that
failed. I think the WIP is in my github, but if not I can push it.
Anyway I don't think this can go in as is.
Tom
next prev parent reply other threads:[~2022-07-09 3:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 16:07 [PATCH v2 0/4] Smart pointer wrapper for frame_info Bruno Larsen
2022-07-08 16:07 ` [PATCH v2 1/4] Remove frame_id_eq Bruno Larsen
2022-07-08 16:07 ` [PATCH v2 2/4] Introduce frame_info_ptr smart pointer class Bruno Larsen
2022-07-09 3:26 ` Tom Tromey [this message]
2022-07-11 12:18 ` Bruno Larsen
2022-07-08 16:07 ` [PATCH v2 4/4] gdb/frame: Add reinflation method for frame_info_ptr Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h73rt19z.fsf@tromey.com \
--to=tom@tromey.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).