From: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 04/36] Delete some unnecessary wrapper functions
Date: Mon, 25 Apr 2022 11:08:05 -0300 [thread overview]
Message-ID: <87h76h8d8l.fsf@linaro.org> (raw)
In-Reply-To: <20220118194007.2853108-5-tom@tromey.com>
Tom Tromey <tom@tromey.com> writes:
> -static void
> -bkpt_create_breakpoints_sal (struct gdbarch *gdbarch,
> - struct linespec_result *canonical,
> - gdb::unique_xmalloc_ptr<char> cond_string,
> - gdb::unique_xmalloc_ptr<char> extra_string,
> - enum bptype type_wanted,
> - enum bpdisp disposition,
> - int thread,
> - int task, int ignore_count,
> - const struct breakpoint_ops *ops,
> - int from_tty, int enabled,
> - int internal, unsigned flags)
> -{
> - create_breakpoints_sal_default (gdbarch, canonical,
> - std::move (cond_string),
> - std::move (extra_string),
> - type_wanted,
> - disposition, thread, task,
> - ignore_count, ops, from_tty,
> - enabled, internal, flags);
> -}
The wrapper here does an std::move() of the string arguments.
> -static void
> -tracepoint_create_breakpoints_sal (struct gdbarch *gdbarch,
> - struct linespec_result *canonical,
> - gdb::unique_xmalloc_ptr<char> cond_string,
> - gdb::unique_xmalloc_ptr<char> extra_string,
> - enum bptype type_wanted,
> - enum bpdisp disposition,
> - int thread,
> - int task, int ignore_count,
> - const struct breakpoint_ops *ops,
> - int from_tty, int enabled,
> - int internal, unsigned flags)
> -{
> - create_breakpoints_sal_default (gdbarch, canonical,
> - std::move (cond_string),
> - std::move (extra_string),
> - type_wanted,
> - disposition, thread, task,
> - ignore_count, ops, from_tty,
> - enabled, internal, flags);
> -}
Here too.
> @@ -14487,8 +14427,8 @@ initialize_breakpoint_ops (void)
> ops->insert_location = bkpt_insert_location;
> ops->remove_location = bkpt_remove_location;
> ops->breakpoint_hit = bkpt_breakpoint_hit;
> - ops->create_sals_from_location = bkpt_create_sals_from_location;
> - ops->create_breakpoints_sal = bkpt_create_breakpoints_sal;
> + ops->create_sals_from_location = create_sals_from_location_default;
> + ops->create_breakpoints_sal = create_breakpoints_sal_default;
> ops->decode_location = bkpt_decode_location;
>
> /* The breakpoint_ops structure to be used in regular breakpoints. */
> @@ -14570,8 +14510,8 @@ initialize_breakpoint_ops (void)
> ops->print_one_detail = tracepoint_print_one_detail;
> ops->print_mention = tracepoint_print_mention;
> ops->print_recreate = tracepoint_print_recreate;
> - ops->create_sals_from_location = tracepoint_create_sals_from_location;
> - ops->create_breakpoints_sal = tracepoint_create_breakpoints_sal;
> + ops->create_sals_from_location = create_sals_from_location_default;
> + ops->create_breakpoints_sal = create_breakpoints_sal_default;
> ops->decode_location = tracepoint_decode_location;
So shouldn't the callers of ops->create_breakpoints_sal () be changed to
do the std::move() themselves?
--
Thiago
next prev parent reply other threads:[~2022-04-25 14:11 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 19:39 [PATCH 00/36] C++-ify breakpoints Tom Tromey
2022-01-18 19:39 ` [PATCH 01/36] Move "catch load" to a new file Tom Tromey
2022-04-23 2:34 ` Simon Marchi
2022-04-24 19:35 ` Tom Tromey
2022-01-18 19:39 ` [PATCH 02/36] Boolify print_solib_event Tom Tromey
2022-01-18 19:39 ` [PATCH 03/36] Add an assertion to clone_momentary_breakpoint Tom Tromey
2022-04-25 13:25 ` Thiago Jung Bauermann
2022-04-25 19:03 ` Tom Tromey
2022-01-18 19:39 ` [PATCH 04/36] Delete some unnecessary wrapper functions Tom Tromey
2022-04-25 14:08 ` Thiago Jung Bauermann [this message]
2022-04-25 19:06 ` Tom Tromey
2022-04-25 20:06 ` Thiago Jung Bauermann
2022-01-18 19:39 ` [PATCH 05/36] Return bool from breakpoint_ops::print_one Tom Tromey
2022-01-18 19:39 ` [PATCH 06/36] Add a vtable-based breakpoint ops Tom Tromey
2022-01-18 19:39 ` [PATCH 07/36] Convert break-catch-sig to use vtable ops Tom Tromey
2022-01-18 19:39 ` [PATCH 08/36] Convert break-catch-syscall to " Tom Tromey
2022-01-18 19:39 ` [PATCH 09/36] Convert break-catch-exec " Tom Tromey
2022-01-18 19:39 ` [PATCH 10/36] Convert break-catch-fork " Tom Tromey
2022-01-18 19:39 ` [PATCH 11/36] Convert break-catch-load " Tom Tromey
2022-01-18 19:39 ` [PATCH 12/36] Convert watchpoints " Tom Tromey
2022-01-18 19:39 ` [PATCH 13/36] Convert tracepoints " Tom Tromey
2022-01-18 19:39 ` [PATCH 14/36] Add some new subclasses of breakpoint Tom Tromey
2022-01-18 19:39 ` [PATCH 15/36] Convert base breakpoints to vtable ops Tom Tromey
2022-05-02 10:27 ` Tom de Vries
2022-05-02 16:40 ` Tom Tromey
2022-01-18 19:39 ` [PATCH 16/36] Convert break-catch-throw " Tom Tromey
2022-01-18 19:39 ` [PATCH 17/36] Convert internal breakpoints " Tom Tromey
2022-01-18 19:39 ` [PATCH 18/36] Convert momentary " Tom Tromey
2022-01-18 19:39 ` [PATCH 19/36] Change inheritance of dprintf Tom Tromey
2022-01-18 19:39 ` [PATCH 20/36] Convert ordinary breakpoints to vtable ops Tom Tromey
2022-01-18 19:39 ` [PATCH 21/36] Convert Ada catchpoints " Tom Tromey
2022-01-18 19:39 ` [PATCH 22/36] Convert dprintf " Tom Tromey
2022-01-18 19:39 ` [PATCH 23/36] Convert ranged breakpoints " Tom Tromey
2022-01-18 19:39 ` [PATCH 24/36] Add bp_static_marker_tracepoint Tom Tromey
2022-01-18 19:39 ` [PATCH 25/36] Convert static marker tracepoints to vtable ops Tom Tromey
2022-01-18 19:39 ` [PATCH 26/36] Remove bkpt_base_breakpoint_ops Tom Tromey
2022-01-18 19:39 ` [PATCH 27/36] Merge probe and ordinary breakpoints Tom Tromey
2022-01-18 19:39 ` [PATCH 28/36] Merge probe and ordinary tracepoints Tom Tromey
2022-01-18 19:40 ` [PATCH 29/36] Remove breakpoint_ops from init_ada_exception_breakpoint Tom Tromey
2022-01-18 19:40 ` [PATCH 30/36] Remove breakpoint_ops from init_catchpoint Tom Tromey
2022-01-18 19:40 ` [PATCH 31/36] Remove most fields from breakpoint_ops Tom Tromey
2022-01-18 19:40 ` [PATCH 32/36] Remove vtable_breakpoint_ops Tom Tromey
2022-01-18 19:40 ` [PATCH 33/36] Remove breakpoint ops initialization Tom Tromey
2022-01-18 19:40 ` [PATCH 34/36] Constify breakpoint_ops Tom Tromey
2022-01-18 19:40 ` [PATCH 35/36] Remove allocate_bp_location Tom Tromey
2022-01-18 19:40 ` [PATCH 36/36] Remove create_breakpoints_sal_default Tom Tromey
2022-04-22 20:21 ` [PATCH 00/36] C++-ify breakpoints Tom Tromey
2022-04-23 2:59 ` Simon Marchi
2022-04-29 22:15 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h76h8d8l.fsf@linaro.org \
--to=thiago.bauermann@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).