From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DFD863858D37 for ; Sun, 3 Apr 2022 14:50:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DFD863858D37 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-561-8sTuxWUtME6bSP-dlUHUbA-1; Sun, 03 Apr 2022 10:50:50 -0400 X-MC-Unique: 8sTuxWUtME6bSP-dlUHUbA-1 Received: by mail-wr1-f72.google.com with SMTP id z16-20020adff1d0000000b001ef7dc78b23so1186602wro.12 for ; Sun, 03 Apr 2022 07:50:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=4B61QAq54kJZNOC4mTgGnx2NXxZo+wWGWf8TocpaChQ=; b=dmWDkO7547tMjM6aQ04MjgnI6dXwC8S/Ak1n0C3HLuVbM6lOl2KXHHLZyI5/OdwBIz lTFyDdFg6keePplNHP53vXQ7YJUWSEwU82A1oOHuAmjyQxIeBLcbbxLFlbhtQ3MAeVoF iVTc29vVRxkJZ6O7+HoKvbMC88C4flzjmnIAWqb6z8Mzr9GeUrPIbnyRP7iwQZjivJnL tuwQk+ptFs/r5iHjKfnTc+4zPedl1Q4ejn3y0/fVCAh1/YAYZpxArVqmkS7TA2cp1eKb cmvXXJH49JB4Pm056VkGVVKNEJAA2TPzDzpUzywjeZehtzIJK7vq2zH+b7pLZQGjHGh6 mukg== X-Gm-Message-State: AOAM5312eHzDz9ZXJV2Cfpz2Ej4blqgrKU5oeAqjV9VuVl+TWSRoukww n4r3/rbAoJjn+T/A3KxKB4IhxkcKHKWAd8c7TWntvzv/Wq8nLa+9J6y5qKFu/dDRAlAIgQCX8rN 1WkToaX2CuXw9i/0QMD4VWz0jFQL2ACxA0X3675pMDs9UmCrn/qsryHq/oNBWJ405v6kXT/5M/g == X-Received: by 2002:adf:dc92:0:b0:203:f998:7f10 with SMTP id r18-20020adfdc92000000b00203f9987f10mr14199182wrj.567.1648997449096; Sun, 03 Apr 2022 07:50:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzh+5FD5uA8dtQvr/0Ea+AHKPq9DqK7W6AqS7hThhSAG1AEEsmQSPukGHoy0uYk37MzcZlHJQ== X-Received: by 2002:adf:dc92:0:b0:203:f998:7f10 with SMTP id r18-20020adfdc92000000b00203f9987f10mr14199174wrj.567.1648997448850; Sun, 03 Apr 2022 07:50:48 -0700 (PDT) Received: from localhost (host86-169-131-113.range86-169.btcentralplus.com. [86.169.131.113]) by smtp.gmail.com with ESMTPSA id c11-20020a05600c0a4b00b0037c91e085ddsm17609632wmq.40.2022.04.03.07.50.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Apr 2022 07:50:48 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCHv2 0/3] Fix for 'make tags' build rule In-Reply-To: References: Date: Sun, 03 Apr 2022 15:50:47 +0100 Message-ID: <87h77a8blk.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Apr 2022 14:50:53 -0000 Andrew Burgess writes: > Hi Reuben, > > Thanks for working on this, sorry your original patch didn't get > merged. > > I took a look at your updated patch, and noticed what I think is a > merge issue with your update, you've removed gdb_select.h, but added > back in gdb_regex.h, I don't think this is intentional. > > Anyway, I was going to fix that and push your patch, but first I > thought I'd test 'make tags' - and I noticed some additional problems. > > The series below fixes these issues. > > #1 - this is a general clean up, and is not really related to 'make > tags' at all, > > #2 - this is your patch, but with the merge issue mentioned above > fixed. > > #3 - this fixes some additional warnings I was seeing from 'make > tags'. > > I'll give this some time for folk to comment before pushing. I've gone ahead and pushed this series. I think all the fixes are reasonably obvious. Thanks, Andrew > > Thanks for your work on this, > > Andrew > > --- > > Andrew Burgess (2): > gdb/Makefile.in: remove SOURCES variable > gdb/Makefile.in: move ALLDEPFILES earlier in Makefile.in > > Reuben Thomas (1): > gdb/Makefile.in: fix 'make tags' build target > > gdb/Makefile.in | 449 ++++++++++++++++++++++++------------------------ > 1 file changed, 229 insertions(+), 220 deletions(-) > > -- > 2.25.4