Re: [PATCH 1/2][PR fortran/26373][PR fortran/22497] gdb/fortran: add support for accessing fields of extended types

[Tom Tromey <tom@tromey.com>]

>>>>> ">" == Nils-Christian Kempke via Gdb-patches <gdb-patches@sourceware.org> writes:

>> From: Bernhard Heckel <bernhard.heckel@intel.com>
>> Fortran 2003 supports type extension.  This patch allows access
>> to inherited members by using their fully qualified name as described
>> in the Fortran standard.

Thanks for the patch.

>> In doing so the patch also fixes a bug in GDB when trying to access the
>> members of a base class in a derived class via the derived class' base
>> class member.

>> @@ -2374,6 +2374,12 @@ value_struct_elt (struct value **argp,
>>        if (v)
>>  	return v;
 
>> +      /* Fortran: If it is not a field it is the type name of an inherited
>> +	 structure.  */
>> +      v = search_struct_field (name, *argp, t, 1);
>> +      if (v)
>> +	return v;

Putting this here makes me wonder if it's possible to construct test
cases in other languages that would work without this patch and then
fail with it.

I'm not sure what the options are though.  Doing the work elsewhere, say
in a custom Fortran expression operation, might make the Python API
harder to work with.  Maybe having value_struct_elt check
current_language would work... that's also quite ugly but other value
operations are doing that.

Or maybe my fears are overblown.

Any thoughts on this?

Tom