From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH] gdbsupport: fix array-view compilation with c++11 && _GLIBCXX_DEBUG
Date: Fri, 19 Nov 2021 13:29:57 -0700 [thread overview]
Message-ID: <87h7c7any2.fsf@tromey.com> (raw)
In-Reply-To: <20211118204145.2425971-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Thu, 18 Nov 2021 15:41:45 -0500")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
Simon> This is because constexpr functions in C++ can only consist of a single
Simon> return statement, so we can't have the gdb_assert in there. Make the
Simon> gdb_assert presence conditional to the __cplusplus version, to enable it
Simon> only for c++14 and later.
Seems fine to me. Thanks.
Tom
next prev parent reply other threads:[~2021-11-19 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 20:41 Simon Marchi
2021-11-19 20:29 ` Tom Tromey [this message]
2021-11-20 4:26 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7c7any2.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).