From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.143.35]) by sourceware.org (Postfix) with ESMTPS id 1BEF6385840D for ; Fri, 19 Nov 2021 20:30:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1BEF6385840D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 412DF82CAB for ; Fri, 19 Nov 2021 14:29:58 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id oAWEmNMsZL3b1oAWEmm5GB; Fri, 19 Nov 2021 14:29:58 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xQJKA70+aW127Kof2cvM2rq6aGv1PvfAOLLuJMEjRk8=; b=quOBJgPNwp5zckh5vtEhqwagbm FleQWVM5NJsrgsWDTGbRnhIWcHhXo4pYyRyGbgO73jkNJ8elbGIlm7fpiz8dLCI/S4qKG3nrM2FO3 KPyQ5VcjwWjBMMpdbhu5tD45M; Received: from 97-122-68-246.hlrn.qwest.net ([97.122.68.246]:54214 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1moAWD-002mc4-Ti; Fri, 19 Nov 2021 13:29:57 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH] gdbsupport: fix array-view compilation with c++11 && _GLIBCXX_DEBUG References: <20211118204145.2425971-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Fri, 19 Nov 2021 13:29:57 -0700 In-Reply-To: <20211118204145.2425971-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Thu, 18 Nov 2021 15:41:45 -0500") Message-ID: <87h7c7any2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.246 X-Source-L: No X-Exim-ID: 1moAWD-002mc4-Ti X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-246.hlrn.qwest.net (murgatroyd) [97.122.68.246]:54214 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Nov 2021 20:30:55 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> This is because constexpr functions in C++ can only consist of a single Simon> return statement, so we can't have the gdb_assert in there. Make the Simon> gdb_assert presence conditional to the __cplusplus version, to enable it Simon> only for c++14 and later. Seems fine to me. Thanks. Tom