Re: [PATCH] gdb: make iterate_over_threads a template function

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> This started off as changing the return type of the callback function
Andrew> that iterate_over_threads takes from int to bool.

Andrew> But then I thought, why not make the whole thing templated, and remove
Andrew> the need to pass void* arguments around.

The usual way to do this in gdb is to have the iteration function accept
a gdb::function_view.  This lets it work with lambdas, etc.

That said, I tend to agree with Simon's response here.  In particular,
so-called "external iteration" is, IMO, usually simpler to read and
understand, and is also more accommodating to special cases.  That may
be a bigger change than you want to make though.

thanks,
Tom