From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.143.234]) by sourceware.org (Postfix) with ESMTPS id EA5AB385802D for ; Mon, 24 May 2021 13:58:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EA5AB385802D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 6A9199E77D for ; Mon, 24 May 2021 08:56:41 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id lB4TldgJR8uM0lB4TlrS6b; Mon, 24 May 2021 08:56:41 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MU1Etzmc/Z0w5LMGjh8PJqNxhnJMn7WnncmPA8BVvNk=; b=egVfYW4ZIH57626YKVgsAd1nVb 0W5R6nuJekE0Tu7jykOT3TRhOSIGdCXfvy/M9yk/GPFXeYmPWbXPvJP8Wchcyca8VG93ZP9s74RuO aILSeLkPocFfAxiStsN2cEmdA; Received: from 75-166-134-27.hlrn.qwest.net ([75.166.134.27]:46796 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1llB4S-002nMj-U6; Mon, 24 May 2021 07:56:40 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: make iterate_over_threads a template function References: <20210522165146.4113176-1-andrew.burgess@embecosm.com> X-Attribution: Tom Date: Mon, 24 May 2021 07:56:40 -0600 In-Reply-To: <20210522165146.4113176-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Sat, 22 May 2021 17:51:46 +0100") Message-ID: <87h7isz147.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.134.27 X-Source-L: No X-Exim-ID: 1llB4S-002nMj-U6 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-134-27.hlrn.qwest.net (murgatroyd) [75.166.134.27]:46796 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3026.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 May 2021 13:58:34 -0000 >>>>> "Andrew" == Andrew Burgess writes: Andrew> This started off as changing the return type of the callback function Andrew> that iterate_over_threads takes from int to bool. Andrew> But then I thought, why not make the whole thing templated, and remove Andrew> the need to pass void* arguments around. The usual way to do this in gdb is to have the iteration function accept a gdb::function_view. This lets it work with lambdas, etc. That said, I tend to agree with Simon's response here. In particular, so-called "external iteration" is, IMO, usually simpler to read and understand, and is also more accommodating to special cases. That may be a bigger change than you want to make though. thanks, Tom