Re: [PATCH] Fix issues with reading rnglists, especially from dwo files, for DWARF v5

[Tom Tromey <tom@tromey.com>]

>>>>> "Caroline" == Caroline Tice via Gdb-patches <gdb-patches@sourceware.org> writes:

Thanks for the patch.

Caroline> +          /* if (dwarf2_attr_no_follow (comp_unit_die, DW_AT_ranges)) */

No need for commented-out code.

Caroline> +          if (comp_unit_die->attr (DW_AT_ranges) != nullptr)
Caroline> +            {
Caroline> +              cu->cu_ranges_from_skeleton = true;
Caroline> +            }

You can remove the braces here.  Normally in gdb there are only braces
if there are multiple statements (or a comment).

Caroline> +  if (tag == DW_TAG_compile_unit &&
Caroline> +      cu->cu_ranges_from_skeleton)

The GNU / gdb style is to break before operators, not after (including
assignment FWIW).  There are several occurrences of this, I didn't mark
them all.

Caroline> +  if (section == nullptr)
Caroline> +    error(_("Cannot find .debug_rnglists section [in module %s]"),

Space before "(".

Caroline> diff --git a/testsuite/gdb.dwarf2/dw5-rnglist-test.cc b/testsuite/gdb.dwarf2/dw5-rnglist-test.cc
Caroline> new file mode 100644
Caroline> index 0000000..4d650e1279
Caroline> --- /dev/null
Caroline> +++ b/testsuite/gdb.dwarf2/dw5-rnglist-test.cc
Caroline> @@ -0,0 +1,71 @@
Caroline> +#include <iostream>

Tests also need the copyright header.

Caroline> diff --git a/testsuite/gdb.dwarf2/dw5-rnglist-test.exp b/testsuite/gdb.dwarf2/dw5-rnglist-test.exp
Caroline> new file mode 100644
Caroline> index 0000000..b5c6c3bfe3
Caroline> --- /dev/null
Caroline> +++ b/testsuite/gdb.dwarf2/dw5-rnglist-test.exp
Caroline> @@ -0,0 +1,40 @@
Caroline> +# Copyright 2011-2020 Free Software Foundation, Inc.

This should probably just be 2020.

Tom