From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway23.websitewelcome.com (gateway23.websitewelcome.com [192.185.49.60]) by sourceware.org (Postfix) with ESMTPS id 6D781387085D for ; Thu, 18 Jun 2020 20:27:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6D781387085D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway23.websitewelcome.com (Postfix) with ESMTP id E7F9C3027 for ; Thu, 18 Jun 2020 15:27:25 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id m189jgVZ1QyTQm189juZUu; Thu, 18 Jun 2020 15:27:25 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TBtGGzuh9Ef0oNAt/YMp4OXDPWhGj3oli07g6VlTNlE=; b=xCJYlhRavmJ8iV2xiUAluihfx5 IdZdWnuUHyrcItvQtYZYV9lt1UpwKPnK3iV5IS6gmGy4Ctre/V9MmhMczn3vBi71xVpmYn+7acfJk 1CLbGzJnM50+8PJw6UbhT5uHI; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:57146 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jm189-003e8K-L5; Thu, 18 Jun 2020 14:27:25 -0600 From: Tom Tromey To: Caroline Tice via Gdb-patches Cc: Tom Tromey , Caroline Tice , Eric Christopher Subject: Re: [PATCH] Fix issues with reading rnglists, especially from dwo files, for DWARF v5 References: <87lfl634rs.fsf@tromey.com> <87h7vsqk5h.fsf@tromey.com> X-Attribution: Tom Date: Thu, 18 Jun 2020 14:27:24 -0600 In-Reply-To: (Caroline Tice via Gdb-patches's message of "Tue, 9 Jun 2020 16:32:15 -0700") Message-ID: <87h7v815n7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jm189-003e8K-L5 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:57146 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3037.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_NUMSUBJECT, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2020 20:27:28 -0000 >>>>> "Caroline" == Caroline Tice via Gdb-patches writes: Thanks for the patch. Caroline> + /* if (dwarf2_attr_no_follow (comp_unit_die, DW_AT_ranges)) */ No need for commented-out code. Caroline> + if (comp_unit_die->attr (DW_AT_ranges) != nullptr) Caroline> + { Caroline> + cu->cu_ranges_from_skeleton = true; Caroline> + } You can remove the braces here. Normally in gdb there are only braces if there are multiple statements (or a comment). Caroline> + if (tag == DW_TAG_compile_unit && Caroline> + cu->cu_ranges_from_skeleton) The GNU / gdb style is to break before operators, not after (including assignment FWIW). There are several occurrences of this, I didn't mark them all. Caroline> + if (section == nullptr) Caroline> + error(_("Cannot find .debug_rnglists section [in module %s]"), Space before "(". Caroline> diff --git a/testsuite/gdb.dwarf2/dw5-rnglist-test.cc b/testsuite/gdb.dwarf2/dw5-rnglist-test.cc Caroline> new file mode 100644 Caroline> index 0000000..4d650e1279 Caroline> --- /dev/null Caroline> +++ b/testsuite/gdb.dwarf2/dw5-rnglist-test.cc Caroline> @@ -0,0 +1,71 @@ Caroline> +#include Tests also need the copyright header. Caroline> diff --git a/testsuite/gdb.dwarf2/dw5-rnglist-test.exp b/testsuite/gdb.dwarf2/dw5-rnglist-test.exp Caroline> new file mode 100644 Caroline> index 0000000..b5c6c3bfe3 Caroline> --- /dev/null Caroline> +++ b/testsuite/gdb.dwarf2/dw5-rnglist-test.exp Caroline> @@ -0,0 +1,40 @@ Caroline> +# Copyright 2011-2020 Free Software Foundation, Inc. This should probably just be 2020. Tom