From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.147.108]) by sourceware.org (Postfix) with ESMTPS id 57853386F47D for ; Thu, 28 May 2020 14:43:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 57853386F47D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway33.websitewelcome.com (Postfix) with ESMTP id BD7094628E8 for ; Thu, 28 May 2020 09:43:06 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id eJkQjNK7yEfyqeJkQj3DMy; Thu, 28 May 2020 09:43:06 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZzdZ+2Bv4WvFpxbr1tV63cEQRviGGiH6oaR9CuwfsBQ=; b=cyOcQO4eL/X2RKgo8MCQ7BvtI6 n5GwJZPgtCIJ/B8lv0DOtSMpFg/JfR1hIklpX145hqvwIqMFSv5yGFZACx9XQXh1Z/0TZPo5oH2n1 cBaLPxCWIHcQKTIMaqMC/IRNM; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:53632 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jeJkQ-003ssA-Bj; Thu, 28 May 2020 08:43:06 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH] gdb/testsuite: introduce save_procs proc References: <20200527215015.15106-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Thu, 28 May 2020 08:43:05 -0600 In-Reply-To: <20200527215015.15106-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Wed, 27 May 2020 17:50:15 -0400") Message-ID: <87h7w0i0hy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jeJkQ-003ssA-Bj X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:53632 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2020 14:43:09 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> The test gdb.base/dbx.exp redefines gdb_file_cmd, which is normally Simon> defined in lib/gdb.exp. It restores the original version of the proc at Simon> the end. But the problem is that if the test fails and an Simon> exception is thrown, it won't be restored and the following tests will Simon> be affected. Although I'd rather we not encourage proc overriding like this, on the other hand I guess there's nothing really wrong with what you're doing. Simon> # file into gdb for a dbx session. So why not just override gdb_file_cmd with the Simon> # right sequence of events, allowing gdb_load to do its normal thing? This way Simon> # remotes and simulators will work, too. This comment indicates that this has always been a hack :) Simon> + # Save args and bodies of specified procs. Simon> + foreach proc_name $procs { Simon> + set proc_args [info args $proc_name] Simon> + set proc_body [info body $proc_name] Simon> + Simon> + set saved($proc_name) [list $proc_args $proc_body] Here you could store [list proc $proc_name $proc_args $proc_body] Simon> + # Restore procs. Simon> + foreach {proc_name value} [array get saved] { Simon> + set proc_args [lindex $value 0] Simon> + set proc_body [lindex $value 1] Simon> + Simon> + eval proc $proc_name {$proc_args} {$proc_body} Then this weird-looking construct could be replaced with the simpler eval $value Tom