From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFC 1/8] Change wrap buffering to use a std::string
Date: Mon, 08 Oct 2018 22:04:00 -0000 [thread overview]
Message-ID: <87h8hwccyd.fsf@tromey.com> (raw)
In-Reply-To: <9ac8cf66-040e-b11a-841b-4d378b256f8a@simark.ca> (Simon Marchi's message of "Sat, 6 Oct 2018 11:19:18 -0400")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>> Currently wrap buffering is implemented by allocating a string that is
>> the same width as the window, and then writing characters into it.
>> However, if gdb emits terminal escapes, then these could possibly
>> overflow the buffer.
>>
>> To prevent this, change the wrap buffer to be a std::string and update
>> the various uses.
Simon> This looks like a good change to me, independently of this series. I think you
Simon> should push it right away.
FWIW I think this patch will have to change to accommodate Windows -- or
at least be totally obsoleted by the needed change. My plan is to have
a vector holding strings with their styling. This has to happen because
styling on Windows is done via an API, not via an escape sequence.
Tom
next prev parent reply other threads:[~2018-10-08 22:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 21:13 [RFC 0/8] add terminal styling to gdb Tom Tromey
2018-09-06 21:13 ` [RFC 7/8] Style the gdb welcome message Tom Tromey
2018-09-06 21:13 ` [RFC 1/8] Change wrap buffering to use a std::string Tom Tromey
2018-10-06 15:19 ` Simon Marchi
2018-10-08 22:04 ` Tom Tromey [this message]
2018-10-18 22:16 ` Tom Tromey
2018-09-06 21:13 ` [RFC 2/8] Add a "context" argument to add_setshow_enum_cmd Tom Tromey
2018-09-06 21:13 ` [RFC 4/8] Add variable name styling Tom Tromey
2018-10-06 16:34 ` Simon Marchi
2018-09-06 21:13 ` [RFC 6/8] Style print_address_symbolic Tom Tromey
2018-09-06 21:13 ` [RFC 3/8] Add output styles to gdb Tom Tromey
2018-10-06 15:53 ` Simon Marchi
2018-10-06 19:06 ` Tom Tromey
2018-10-07 21:58 ` Simon Marchi
2018-10-08 0:23 ` Tom Tromey
2018-10-08 2:02 ` Simon Marchi
2018-10-08 2:49 ` Tom Tromey
2018-10-08 11:10 ` Simon Marchi
2018-10-08 22:17 ` Tom Tromey
2018-09-06 21:14 ` [RFC 5/8] Style locations when setting a breakpoint Tom Tromey
2018-10-06 16:36 ` Simon Marchi
2018-09-06 21:14 ` [RFC 8/8] Style the "Reading symbols" message Tom Tromey
2018-09-07 6:23 ` [RFC 0/8] add terminal styling to gdb Eli Zaretskii
2018-09-07 14:36 ` Tom Tromey
2018-09-07 14:56 ` Eli Zaretskii
2018-09-07 15:01 ` Eli Zaretskii
2018-09-07 7:25 ` Joel Brobecker
2018-10-04 13:11 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8hwccyd.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).