From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92115 invoked by alias); 7 Oct 2018 05:14:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92090 invoked by uid 89); 7 Oct 2018 05:14:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=BAYES_00,KAM_STOCKGEN,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=investigate, mandatory, reviewing, parent X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 07 Oct 2018 05:14:20 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 95B2D308AA14; Sun, 7 Oct 2018 05:14:19 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6176560BE8; Sun, 7 Oct 2018 05:14:19 +0000 (UTC) From: Sergio Durigan Junior To: Richard Bunt Cc: Tom Tromey , "gdb-patches\@sourceware.org" , nd Subject: New FAILs on gdb.fortran/short-circuit-argument-list.exp when testing on native{,-extended}-gdbserver (was: Re: [PATCH v3] Logical short circuiting with argument lists) References: <833f15b2-48da-fe83-86c8-3c2bce46b01c@arm.com> <87lg833ibu.fsf@tromey.com> <8ab527d2-3685-c5ea-03f2-0c71dabe2a07@arm.com> Date: Sun, 07 Oct 2018 05:14:00 -0000 In-Reply-To: <8ab527d2-3685-c5ea-03f2-0c71dabe2a07@arm.com> (Richard Bunt's message of "Tue, 18 Sep 2018 18:39:29 +0000") Message-ID: <87h8hypcd1.fsf_-_@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00159.txt.bz2 On Tuesday, September 18 2018, Richard Bunt wrote: > On 09/14/2018 10:00 PM, Tom Tromey wrote: >>>>>>> "Richard" == Richard Bunt writes: >> >> Richard> Version 3 addresses review comments: >> >> Richard> * Removed forward declaration of skip_undetermined_arglist. >> Richard> * Made definition of skip_undetermined_arglist static. >> Richard> * Added introductory comment to skip_undetermined_arglist. >> Richard> * Dropped (*pos)+=3 into the block. >> Richard> * Adjusted Tcl bracing. >> Richard> * Removed string splitting in the test case. >> >> Thanks again for the patch. >> >> Richard> + if (noside != EVAL_SKIP) >> Richard> + { >> Richard> + return evaluate_var_value (noside, exp->elts[pc + 1].block, var); >> Richard> + } >> >> The gdb style is no braces if there's just a single line. >> >> Richard> + else >> Richard> + { >> Richard> + /* Return a dummy value of the correct type when skipping, so >> Richard> + that parent functions know what is to be skipped. */ >> Richard> + return allocate_value (SYMBOL_TYPE (var)); >> >> ... compared to here, where braces are mandatory. >> >> This patch is ok with that first set of braces removed. >> (You don't have to re-send it.) >> >> thanks, >> Tom >> > > Many thanks for reviewing this change. I will fix up the braces and push. Hi Richard, Just a heads up, I've noticed a few failures when running gdb.fortran/short-circuit-argument-list.exp on a native{,-extended}-gdbserver board: FAIL: gdb.fortran/short-circuit-argument-list.exp: arg=No: p function_no_arg_false() .OR. function_no_arg() FAIL: gdb.fortran/short-circuit-argument-list.exp: arg=One: p function_no_arg_false() .OR. function_one_arg( .TRUE.) FAIL: gdb.fortran/short-circuit-argument-list.exp: arg=Two: p function_no_arg_false() .OR. function_two_arg( .TRUE., .TRUE.) FAIL: gdb.fortran/short-circuit-argument-list.exp: p function_one_arg(.FALSE. .OR. function_no_arg()) FAIL: gdb.fortran/short-circuit-argument-list.exp: p function_one_arg(.TRUE. .OR. function_no_arg()) The failures are easily reproducible, but let me know if you need a gdb.log excerpt. I haven't had the time to investigate them further. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/