From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: -readnow crash Rust regression [Re: [RFA v2 3/4] Convert Rust to use discriminated unions]
Date: Thu, 12 Apr 2018 18:10:00 -0000 [thread overview]
Message-ID: <87h8ognvnu.fsf@tromey.com> (raw)
In-Reply-To: <87vacxle14.fsf@tromey.com> (Tom Tromey's message of "Wed, 11 Apr 2018 13:49:11 -0600")
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
Tom> I have a hack to fix that but it reveals another problem, which is that
Tom> some of the type rewriting can be done multiple times, causing other bugs.
Tom> I hadn't considered this possibility. I'm looking into a good way to
Tom> fix it.
This analysis was mistaken, and it turned out to be simpler -- good
news.
I will send out my patches, but writing a test case for 23010 seems
quite painful. Based on the stack trace I got, and investigating the
DWARF of the reproducer, you need:
* A partial CU with no language, which has a function that has some parameters
* A full C++ CU that references that function using DW_AT_abstract_origin
In the webkit reproducer this DW_AT_abstract_origin occurs in an inlined
function IIRC.
Tom
next prev parent reply other threads:[~2018-04-12 18:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 20:30 [RFA v2 0/4] variants and variant parts Tom Tromey
2018-02-22 20:30 ` [RFA v2 4/4] Handle DW_TAG_variant_part and DW_TAG_variant Tom Tromey
2018-02-26 6:56 ` Joel Brobecker
2018-02-26 16:16 ` Tom Tromey
2018-02-22 20:30 ` [RFA v2 1/4] Sign-extend non-bit-fields in unpack_bits_as_long Tom Tromey
2018-02-26 6:45 ` Joel Brobecker
2018-02-22 20:30 ` [RFA v2 2/4] Initial support for variant parts Tom Tromey
2018-02-26 6:49 ` Joel Brobecker
2018-02-22 20:30 ` [RFA v2 3/4] Convert Rust to use discriminated unions Tom Tromey
2018-02-26 6:50 ` Joel Brobecker
2018-02-27 23:23 ` Pedro Alves
2018-02-28 0:23 ` Tom Tromey
2018-04-10 20:36 ` -readnow crash Rust regression [Re: [RFA v2 3/4] Convert Rust to use discriminated unions] Jan Kratochvil
2018-04-11 2:52 ` Tom Tromey
2018-04-11 7:04 ` Jan Kratochvil
2018-04-11 19:49 ` Tom Tromey
2018-04-12 18:10 ` Tom Tromey [this message]
2018-04-12 18:45 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8ognvnu.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).