From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60661 invoked by alias); 1 Dec 2017 17:21:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60645 invoked by uid 89); 1 Dec 2017 17:21:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=he's, Certainly X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Dec 2017 17:21:31 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 080464A6E6; Fri, 1 Dec 2017 17:21:30 +0000 (UTC) Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 28AF460BF2; Fri, 1 Dec 2017 17:21:27 +0000 (UTC) From: Sergio Durigan Junior To: Tom Tromey Cc: Pedro Alves , GDB Patches , Joel Brobecker , Yao Qi , Eli Zaretskii Subject: Re: [PATCH v4] Add support for the readnever concept References: <1467838463-15786-1-git-send-email-brobecker@adacore.com> <20171130002529.10592-1-sergiodj@redhat.com> <6765d36f-8603-9cd3-0476-801a5bfe0865@redhat.com> <87shcvgj55.fsf@redhat.com> <87mv325pz8.fsf@tromey.com> Date: Fri, 01 Dec 2017 17:21:00 -0000 In-Reply-To: <87mv325pz8.fsf@tromey.com> (Tom Tromey's message of "Fri, 01 Dec 2017 10:15:39 -0700") Message-ID: <87h8tafjop.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00027.txt.bz2 On Friday, December 01 2017, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> On 12/01/2017 04:35 AM, Sergio Durigan Junior wrote: >>>> If readnever_symbol_files is set, then it'll have been propagated to > objfile-> flags before we get here, no? >>> >>> Hm, I think so, yes. I mean, assuming that objfile != NULL when we call >>> the readers, then yes; > > Pedro> Certainly you can assume that. A reader's job is to read > Pedro> in the passed in objfile. The very first line of elf_symfile_read > Pedro> would immediately crash otherwise, for example. > > Perhaps an ATTRIBUTE_NONNULL is in order somewhere. I thought about a gdb_assert, actually. But yeah, I agree. I'll push what Pedro has approved, and if he's OK with it, I'll prepare a patch with a gdb_assert. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/