From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23740 invoked by alias); 23 May 2016 17:22:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23693 invoked by uid 89); 23 May 2016 17:22:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:531 X-HELO: gproxy9-pub.mail.unifiedlayer.com Received: from gproxy9-pub.mail.unifiedlayer.com (HELO gproxy9-pub.mail.unifiedlayer.com) (69.89.20.122) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Mon, 23 May 2016 17:22:19 +0000 Received: (qmail 4154 invoked by uid 0); 23 May 2016 17:22:17 -0000 Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy9.mail.unifiedlayer.com with SMTP; 23 May 2016 17:22:17 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id xtNE1s00C2f2jeq01tNH6J; Mon, 23 May 2016 11:22:17 -0600 X-Authority-Analysis: v=2.1 cv=EftbHpWC c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=PnD2wP_eR3oA:10 a=_v2sUkyEFrwA:10 a=yrkiwgmsf1kA:10 a=ifsQJ1_Y-N0u7R6sn3sA:9 Received: from [71.215.116.141] (port=48096 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.86_2) (envelope-from ) id 1b4tYT-00054R-QG; Mon, 23 May 2016 11:22:14 -0600 From: Tom Tromey To: Yao Qi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA] Fix PR python/17386 - add __index__ method to gdb.Value References: <1463616830-12259-1-git-send-email-tom@tromey.com> <86a8jh8972.fsf@gmail.com> Date: Mon, 23 May 2016 17:22:00 -0000 In-Reply-To: <86a8jh8972.fsf@gmail.com> (Yao Qi's message of "Mon, 23 May 2016 09:33:53 +0100") Message-ID: <87h9dowuyl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 71.215.116.141 authed with tom+tromey.com} X-SW-Source: 2016-05/txt/msg00399.txt.bz2 Yao> This change should be in a separate patch. Could you split it? It is Yao> obvious and can be applied. I'll send v2 shortly. The original patch was wrong, due to me not building against Python 3. With the new patch I've done it both ways. Yao> These two exceptions look quite similar but can you add a test that Yao> triggers "'gdb.Value' object cannot be interpreted as an integer"? Yao> because that is the symptom this patch is to fix. v2 has this. Tom