From: Tom Tromey <tromey@redhat.com>
To: Adrian Sendroiu <adrian.sendroiu@freescale.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/2] mi-out: Implement mi redirection using a stack.
Date: Thu, 24 Jul 2014 20:34:00 -0000 [thread overview]
Message-ID: <87ha26liw6.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1406125575-28311-3-git-send-email-adrian.sendroiu@freescale.com> (Adrian Sendroiu's message of "Wed, 23 Jul 2014 17:26:15 +0300")
>>>>> "Adrian" == Adrian Sendroiu <adrian.sendroiu@freescale.com> writes:
Adrian> gdb/
Adrian> 2014-07-23 Adrian Sendroiu <adrian.sendroiu@freescale.com>
Adrian> * mi/mi-out.c (ui_filep): New typedef.
[...]
I think it would be good to have some text in the message describing the
rationale for this patch.
One nit below.
Adrian> /* FIXME: This code should be using a ``string_file'' and not the
Adrian> TUI buffer hack. */
Not your problem but I wonder what this FIXME comment means.
I suspect it's obsolete since as far as I know mem_fileopen does return
a "string_file".
Adrian> + new_stream = mem_fileopen();
Space before the open paren.
The patch is ok with this fixed and with some rationale text.
thanks,
Tom
next prev parent reply other threads:[~2014-07-24 18:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 14:26 [PATCH 0/2] Reimplement redirection for MI Adrian Sendroiu
2014-07-23 14:26 ` [PATCH 2/2] mi-out: Implement mi redirection using a stack Adrian Sendroiu
2014-07-24 20:34 ` Tom Tromey [this message]
2014-07-25 11:43 ` [PATCH v2 " Adrian Sendroiu
2014-07-29 15:16 ` Pedro Alves
2014-07-30 8:38 ` Adrian Sendroiu
2014-07-30 12:05 ` Pedro Alves
2014-07-31 16:23 ` Adrian Sendroiu
2014-07-31 17:11 ` Pedro Alves
2014-08-05 13:54 ` Adrian Sendroiu
2014-08-28 11:33 ` Adrian Sendroiu
2014-09-05 16:06 ` Pedro Alves
2014-09-07 15:45 ` Adrian Sendroiu
2014-09-08 13:19 ` Pedro Alves
2014-09-08 18:59 ` Sergio Durigan Junior
2014-09-09 14:03 ` Adrian Sendroiu
2014-09-26 9:25 ` Adrian Sendroiu
2014-09-26 12:51 ` Pedro Alves
2014-07-23 14:37 ` [PATCH 1/2] cli/cli-logging.c: don't call ui_out_redirect for MI when disabling logging Adrian Sendroiu
2014-07-24 18:19 ` Tom Tromey
2015-08-17 18:47 ` [PATCH 0/2] Reimplement redirection for MI Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ha26liw6.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=adrian.sendroiu@freescale.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).