From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2907 invoked by alias); 24 Jul 2014 18:19:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2861 invoked by uid 89); 24 Jul 2014 18:19:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 24 Jul 2014 18:19:12 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6OIJ8YW032581 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Jul 2014 14:19:08 -0400 Received: from barimba (ovpn-113-99.phx2.redhat.com [10.3.113.99]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6OIJ5lC029374 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 24 Jul 2014 14:19:07 -0400 From: Tom Tromey To: Adrian Sendroiu Cc: Subject: Re: [PATCH 2/2] mi-out: Implement mi redirection using a stack. References: <1406125575-28311-1-git-send-email-adrian.sendroiu@freescale.com> <1406125575-28311-3-git-send-email-adrian.sendroiu@freescale.com> Date: Thu, 24 Jul 2014 20:34:00 -0000 In-Reply-To: <1406125575-28311-3-git-send-email-adrian.sendroiu@freescale.com> (Adrian Sendroiu's message of "Wed, 23 Jul 2014 17:26:15 +0300") Message-ID: <87ha26liw6.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-07/txt/msg00651.txt.bz2 >>>>> "Adrian" == Adrian Sendroiu writes: Adrian> gdb/ Adrian> 2014-07-23 Adrian Sendroiu Adrian> * mi/mi-out.c (ui_filep): New typedef. [...] I think it would be good to have some text in the message describing the rationale for this patch. One nit below. Adrian> /* FIXME: This code should be using a ``string_file'' and not the Adrian> TUI buffer hack. */ Not your problem but I wonder what this FIXME comment means. I suspect it's obsolete since as far as I know mem_fileopen does return a "string_file". Adrian> + new_stream = mem_fileopen(); Space before the open paren. The patch is ok with this fixed and with some rationale text. thanks, Tom