From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-113265-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10934 invoked by alias); 6 Jun 2014 19:42:10 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 10923 invoked by uid 89); 6 Jun 2014 19:42:09 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: albireo.enyo.de
Received: from albireo.enyo.de (HELO albireo.enyo.de) (46.237.207.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 06 Jun 2014 19:42:07 +0000
Received: from [172.17.203.2] (helo=deneb.enyo.de)	by albireo.enyo.de with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128)	id 1Wt01a-0005yO-1f; Fri, 06 Jun 2014 21:42:02 +0200
Received: from fw by deneb.enyo.de with local (Exim 4.80)	(envelope-from <fw@deneb.enyo.de>)	id 1Wt01Z-0008Sr-Qf; Fri, 06 Jun 2014 21:42:01 +0200
From: Florian Weimer <fw@deneb.enyo.de>
To: Gary Benson <gbenson@redhat.com>
Cc: gdb-patches@sourceware.org,  Andrew Burgess <aburgess@broadcom.com>,  Doug Evans <xdje42@gmail.com>,  Eli Zaretskii <eliz@gnu.org>,  Mark Kettenis <mark.kettenis@xs4all.nl>,  Pedro Alves <palves@redhat.com>,  Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH 3/3 v4] Demangler crash handler
References: <20140605130140.GA20572@blade.nx>	<20140605130358.GD20572@blade.nx> <87a99pewec.fsf@mid.deneb.enyo.de>	<20140606192741.GA6811@blade.nx>
Date: Fri, 06 Jun 2014 19:42:00 -0000
In-Reply-To: <20140606192741.GA6811@blade.nx> (Gary Benson's message of "Fri,	6 Jun 2014 20:27:41 +0100")
Message-ID: <87ha3xddva.fsf@mid.deneb.enyo.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
X-SW-Source: 2014-06/txt/msg00337.txt.bz2

* Gary Benson:

> Florian Weimer wrote:
>> * Gary Benson:
>> > +      sigaction (SIGSEGV, &sa, &old_sa);
>> > +      crash_signal = SIGSETJMP (gdb_demangle_jmp_buf);
>> > +      sigaction (SIGSEGV, &old_sa, NULL);
>> 
>> That's quite a bit of additional work for each demangler invocation.
>> Is this visible with things like tab completion?
>
> I tested this a while back: it's not noticable.
>
> FWIW I did time gdb -nx -batch \
>                 /usr/lib64/libreoffice/program/soffice.bin \
>                 -ex "start" -ex "complete b" > /dev/null
>
> That invokes the demangler some 3,100,000 times.  I don't remember
> the exact times but they were of the order of 50s in both cases.

Good to know, thanks.