From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25657 invoked by alias); 16 May 2014 18:24:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25645 invoked by uid 89); 16 May 2014 18:24:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 May 2014 18:24:13 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4GIO8Xt019327 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 16 May 2014 14:24:09 -0400 Received: from barimba (ovpn-113-182.phx2.redhat.com [10.3.113.182]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4GIO7Pr011698 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Fri, 16 May 2014 14:24:08 -0400 From: Tom Tromey To: Simon Marchi Cc: Subject: Re: [PATCH] PR mi/15806: Fix quoting of async events References: <1398568091-21253-1-git-send-email-simon.marchi@ericsson.com> <878uq17mrq.fsf@fleche.redhat.com> <537651BA.3020001@ericsson.com> Date: Fri, 16 May 2014 18:24:00 -0000 In-Reply-To: <537651BA.3020001@ericsson.com> (Simon Marchi's message of "Fri, 16 May 2014 13:58:18 -0400") Message-ID: <87ha4p60qg.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-05/txt/msg00307.txt.bz2 Tom> Did you check the other callers of printchar, even indirect ones? Tom> I did a spot check and didn't see any issues, but it would be reassuring Tom> if you could look. Simon> The only direct callers of printchar are fputstr_filtered, Simon> fputstr_unfiltered, fputstrn_filtered and fputstrn_unfiltered. To the Simon> best of my knowledge, the change should not impact the callers of Simon> those. Yeah, by "indirect ones" I meant callers of these as well. I looked through them. fputstr_unfiltered is safe. fputstrn_filtered is not used. But for fputstrn_unfiltered, I see in remote.c: static char * escape_buffer (const char *buf, int n) [...] fputstrn_unfiltered (buf, n, 0, stb); So it seems like this change could impact remote. To know for sure, you'd have to dig a bit deeper. One option might be to make QUOTER==-1 special, then update the call in mi_console_raw_packet. Simon> Semi-related: while looking at that, I realized that unlike Simon> mi_field_string, mi_field_fmt does no escaping at all. It doesn't seem Simon> like a problem right now, since mi_field_fmt is only used with things Simon> that don't really need escaping anyway (numbers, or hex Simon> strings). Still, it makes an inconsistent API and would be nice to Simon> fix, I think. Yes, that seems like a bug waiting to happen. Tom