* [PATCH 2/5] Updates d_language_defn to not use macro expansion
@ 2014-01-09 13:07 Iain Buclaw
2014-01-09 18:15 ` Tom Tromey
0 siblings, 1 reply; 10+ messages in thread
From: Iain Buclaw @ 2014-01-09 13:07 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 225 bytes --]
D doesn't have macros, so it makes little sense to use macro_expansion_c.
2014-01-09 Iain Buclaw <ibuclaw@gdcproject.org>
* d-lang.c (d_language_defn): Change macro_expansion_c to
macro_expansion_no.
---
[-- Attachment #2: dlang-p2.patch --]
[-- Type: text/x-patch, Size: 907 bytes --]
gdb/ChangeLog | 5 +++++
gdb/d-lang.c | 6 +++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/gdb/d-lang.c b/gdb/d-lang.c
index 13b5438..3775e4b 100644
--- a/gdb/d-lang.c
+++ b/gdb/d-lang.c
@@ -244,7 +244,7 @@ static const struct language_defn d_language_defn =
range_check_off,
case_sensitive_on,
array_row_major,
- macro_expansion_c,
+ macro_expansion_no,
&exp_descriptor_c,
c_parse,
c_error,
@@ -259,8 +259,8 @@ static const struct language_defn d_language_defn =
c_value_print, /* Print a top-level value. */
default_read_var_value, /* la_read_var_value */
NULL, /* Language specific skip_trampoline. */
- "this",
- basic_lookup_symbol_nonlocal,
+ "this", /* name_of_this */
+ basic_lookup_symbol_nonlocal,
basic_lookup_transparent_type,
d_demangle, /* Language specific symbol demangler. */
NULL, /* Language specific
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion
2014-01-09 13:07 [PATCH 2/5] Updates d_language_defn to not use macro expansion Iain Buclaw
@ 2014-01-09 18:15 ` Tom Tromey
2014-01-09 18:32 ` Iain Buclaw
0 siblings, 1 reply; 10+ messages in thread
From: Tom Tromey @ 2014-01-09 18:15 UTC (permalink / raw)
To: Iain Buclaw; +Cc: gdb-patches
>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:
Iain> D doesn't have macros, so it makes little sense to use macro_expansion_c.
Iain> 2014-01-09 Iain Buclaw <ibuclaw@gdcproject.org>
Iain> * d-lang.c (d_language_defn): Change macro_expansion_c to
Iain> macro_expansion_no.
Iain> @@ -259,8 +259,8 @@ static const struct language_defn d_language_defn =
Iain> c_value_print, /* Print a top-level value. */
Iain> default_read_var_value, /* la_read_var_value */
Iain> NULL, /* Language specific skip_trampoline. */
Iain> - "this",
Iain> - basic_lookup_symbol_nonlocal,
Iain> + "this", /* name_of_this */
Iain> + basic_lookup_symbol_nonlocal,
Iain> basic_lookup_transparent_type,
Iain> d_demangle, /* Language specific symbol demangler. */
Iain> NULL, /* Language specific
Spurious change.
This patch is ok with this removed.
Tom
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion
2014-01-09 18:15 ` Tom Tromey
@ 2014-01-09 18:32 ` Iain Buclaw
2014-01-10 12:06 ` Iain Buclaw
0 siblings, 1 reply; 10+ messages in thread
From: Iain Buclaw @ 2014-01-09 18:32 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
On 9 January 2014 18:15, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:
>
> Iain> D doesn't have macros, so it makes little sense to use macro_expansion_c.
> Iain> 2014-01-09 Iain Buclaw <ibuclaw@gdcproject.org>
>
> Iain> * d-lang.c (d_language_defn): Change macro_expansion_c to
> Iain> macro_expansion_no.
>
> Iain> @@ -259,8 +259,8 @@ static const struct language_defn d_language_defn =
> Iain> c_value_print, /* Print a top-level value. */
> Iain> default_read_var_value, /* la_read_var_value */
> Iain> NULL, /* Language specific skip_trampoline. */
> Iain> - "this",
> Iain> - basic_lookup_symbol_nonlocal,
> Iain> + "this", /* name_of_this */
> Iain> + basic_lookup_symbol_nonlocal,
> Iain> basic_lookup_transparent_type,
> Iain> d_demangle, /* Language specific symbol demangler. */
> Iain> NULL, /* Language specific
>
> Spurious change.
> This patch is ok with this removed.
>
It was a comment found in every other language file, it was useful
when I was studying how things were set-up. Can remove it.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion
2014-01-09 18:32 ` Iain Buclaw
@ 2014-01-10 12:06 ` Iain Buclaw
2014-01-10 17:14 ` Tom Tromey
0 siblings, 1 reply; 10+ messages in thread
From: Iain Buclaw @ 2014-01-10 12:06 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
On 9 January 2014 18:32, Iain Buclaw <ibuclaw@gdcproject.org> wrote:
> On 9 January 2014 18:15, Tom Tromey <tromey@redhat.com> wrote:
>>
>> Spurious change.
>> This patch is ok with this removed.
>>
>
> It was a comment found in every other language file, it was useful
> when I was studying how things were set-up. Can remove it.
Removed and rebased patch.
---
[-- Attachment #2: dlang-p2.patch --]
[-- Type: text/x-patch, Size: 437 bytes --]
gdb/ChangeLog | 5 +++++
gdb/d-lang.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/d-lang.c b/gdb/d-lang.c
index 13b5438..766b5fa 100644
--- a/gdb/d-lang.c
+++ b/gdb/d-lang.c
@@ -244,7 +244,7 @@ static const struct language_defn d_language_defn =
range_check_off,
case_sensitive_on,
array_row_major,
- macro_expansion_c,
+ macro_expansion_no,
&exp_descriptor_c,
c_parse,
c_error,
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion
2014-01-10 12:06 ` Iain Buclaw
@ 2014-01-10 17:14 ` Tom Tromey
2014-01-16 10:59 ` Iain Buclaw
2014-01-18 18:21 ` Iain Buclaw
0 siblings, 2 replies; 10+ messages in thread
From: Tom Tromey @ 2014-01-10 17:14 UTC (permalink / raw)
To: Iain Buclaw; +Cc: gdb-patches
>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:
Iain> Removed and rebased patch.
FAOD this is ok.
Tom
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion
2014-01-10 17:14 ` Tom Tromey
@ 2014-01-16 10:59 ` Iain Buclaw
2014-01-16 14:34 ` Tom Tromey
2014-01-18 18:21 ` Iain Buclaw
1 sibling, 1 reply; 10+ messages in thread
From: Iain Buclaw @ 2014-01-16 10:59 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
On 10 January 2014 17:14, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:
>
> Iain> Removed and rebased patch.
>
> FAOD this is ok.
>
> Tom
Hi,
Is there anything else needed to be done from me? Just asking as I
noticed a change to the way that requires this patch to be updated.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion
2014-01-16 10:59 ` Iain Buclaw
@ 2014-01-16 14:34 ` Tom Tromey
2014-01-16 17:03 ` Iain Buclaw
0 siblings, 1 reply; 10+ messages in thread
From: Tom Tromey @ 2014-01-16 14:34 UTC (permalink / raw)
To: Iain Buclaw; +Cc: gdb-patches
>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:
Iain> Is there anything else needed to be done from me? Just asking as I
Iain> noticed a change to the way that requires this patch to be updated.
I wasn't keeping score, but if all the patches are approved, you can
rebase (our git repository rejects merge commits on master), merge to
master, and push. If a patch needs any changes during the rebase, you
can use your judgment -- if it is just a trivial change, post the
updated patch as an FYI; if it required some work, usually another round
of review is needed.
If you don't have write-after-approval access, now is a good time to get
it :). Send me email off-list and I will hook you up.
Tom
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion
2014-01-16 14:34 ` Tom Tromey
@ 2014-01-16 17:03 ` Iain Buclaw
2014-01-16 17:11 ` Tom Tromey
0 siblings, 1 reply; 10+ messages in thread
From: Iain Buclaw @ 2014-01-16 17:03 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
On 16 January 2014 14:34, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:
>
> Iain> Is there anything else needed to be done from me? Just asking as I
> Iain> noticed a change to the way that requires this patch to be updated.
>
> I wasn't keeping score, but if all the patches are approved, you can
> rebase (our git repository rejects merge commits on master), merge to
> master, and push. If a patch needs any changes during the rebase, you
> can use your judgment -- if it is just a trivial change, post the
> updated patch as an FYI; if it required some work, usually another round
> of review is needed.
>
It's just trivial, see the change you did to set_main_name (sorry in
advanced for long url link)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blobdiff;f=gdb/symtab.c;h=a8073b8ef7e8027566949952b9115631e33a5f5f;hp=5e988c88efceebfbc90192151e57938884ce62ea;hb=9e6c82ad4f55d0ff125721b94fa2191f1cc1000a;hpb=6ef55de768d4ab9065bc92aa00d828212c4af4f0
Regards
Iain
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion
2014-01-16 17:03 ` Iain Buclaw
@ 2014-01-16 17:11 ` Tom Tromey
0 siblings, 0 replies; 10+ messages in thread
From: Tom Tromey @ 2014-01-16 17:11 UTC (permalink / raw)
To: Iain Buclaw; +Cc: gdb-patches
>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:
Iain> It's just trivial, see the change you did to set_main_name (sorry in
Iain> advanced for long url link)
Iain> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blobdiff;f=gdb/symtab.c;h=a8073b8ef7e8027566949952b9115631e33a5f5f;hp=5e988c88efceebfbc90192151e57938884ce62ea;hb=9e6c82ad4f55d0ff125721b94fa2191f1cc1000a;hpb=6ef55de768d4ab9065bc92aa00d828212c4af4f0
Yeah, it's fine to just post the updated patch as an FYI before pushing.
Tom
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion
2014-01-10 17:14 ` Tom Tromey
2014-01-16 10:59 ` Iain Buclaw
@ 2014-01-18 18:21 ` Iain Buclaw
1 sibling, 0 replies; 10+ messages in thread
From: Iain Buclaw @ 2014-01-18 18:21 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
On 10 January 2014 17:14, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:
>
> Iain> Removed and rebased patch.
>
> FAOD this is ok.
>
> Tom
Thanks, committed to gdb.
Regards
Iain
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-01-18 18:21 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-09 13:07 [PATCH 2/5] Updates d_language_defn to not use macro expansion Iain Buclaw
2014-01-09 18:15 ` Tom Tromey
2014-01-09 18:32 ` Iain Buclaw
2014-01-10 12:06 ` Iain Buclaw
2014-01-10 17:14 ` Tom Tromey
2014-01-16 10:59 ` Iain Buclaw
2014-01-16 14:34 ` Tom Tromey
2014-01-16 17:03 ` Iain Buclaw
2014-01-16 17:11 ` Tom Tromey
2014-01-18 18:21 ` Iain Buclaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).