From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-108646-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9619 invoked by alias); 20 Dec 2013 18:16:42 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 9610 invoked by uid 89); 20 Dec 2013 18:16:41 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Dec 2013 18:16:40 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBKIGcfX010251	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 20 Dec 2013 13:16:38 -0500
Received: from barimba (ovpn-113-93.phx2.redhat.com [10.3.113.93])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBKIGbcD020935	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 20 Dec 2013 13:16:37 -0500
From: Tom Tromey <tromey@redhat.com>
To: Sterling Augustine <saugustine@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>, Keith Seitz <keiths@redhat.com>
Subject: Re: [Patch] Use "<unknown>" instead of NULL when a symbol isn't found
References: <CAEG7qUxE2eiqv0nGe6=UJ9NpsgCAf0WtG2VPtiJpczaWatxwmg@mail.gmail.com>
Date: Fri, 20 Dec 2013 18:16:00 -0000
In-Reply-To: <CAEG7qUxE2eiqv0nGe6=UJ9NpsgCAf0WtG2VPtiJpczaWatxwmg@mail.gmail.com>	(Sterling Augustine's message of "Tue, 17 Dec 2013 11:21:40 -0800")
Message-ID: <87haa3ie0r.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-12/txt/msg00850.txt.bz2

>>>>> "Sterling" == Sterling Augustine <saugustine@google.com> writes:

Sterling> Although the case is hard to tickle--I only found it myself with an
Sterling> object file with an erroneous line table entry--GDB shouldn't crash,
Sterling> and recovery is quite straight-forward.

I wonder whether some correction or workaround is required elsewhere.

Sterling> The following patch simply assigns the symbol name as "<unknown>"
Sterling> instead of NULL, allowing the debugger to make forward progress in the
Sterling> face of an erroneous debug line table entry.

You didn't say whether you regression-tested this; but assuming so, it
is ok.

Tom