From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 561153858C78 for ; Mon, 27 May 2024 21:49:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 561153858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 561153858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716846593; cv=none; b=lvlI5XBGL+L9NcoyVWJSqxoh7LtR65ZljINgKV824IFZFWFgrlKu+jwnpsYsYPuc3hckgN9Nvwl337GjOfxX+xmnP/9AK6e9Ms4VpQQ79jKGtVz6zpXfY3N5RknSZyhb//9AwxAZDatgbtrZxDifeH+UYsmDcnJSTWxK9aroDfE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716846593; c=relaxed/simple; bh=CvXHcaPFqNzA+LaiBUfKAM0VNrKOiGX2OYMIbd5+g74=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=sjaKAnXojC8aHAFhwvlCwLm8sAgkUmk0uIeHqjvyy4nccGg2GBfBVJcrrNZet0goY8bbM7Fa3RRAcL9JNWRKN1Zcds0XrjGhsDW7xVESOxFegPWoE9cqiQOXPT/aiY/0saa6wGiNzpPZYlnKq2QLRLgrFn4HknQN3r73bZxOq1s= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716846591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P7KedKfZnKpJr2kjEiCFDySre9MmX3czhCcMDQlZddY=; b=g4KPH5xYc8/AISTRhO4M1wWCsNPxEMzpOoikgYiywDfMTYlST8ywv+zTrgUjxd+9XR7Zk0 GpGj84su56Imp9OkEVWamgy416Jj+mfV2n24OMhvvgAqPeu/dhMIKrJr1uNbrU6sFn+OPs h/67rivuY/Bx/uuR8exfXZEwBx2/IwQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-118-nOIEx5BaNDSi3tJDETXKWw-1; Mon, 27 May 2024 17:49:49 -0400 X-MC-Unique: nOIEx5BaNDSi3tJDETXKWw-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-357f24b8cabso74908f8f.3 for ; Mon, 27 May 2024 14:49:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716846588; x=1717451388; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P7KedKfZnKpJr2kjEiCFDySre9MmX3czhCcMDQlZddY=; b=qEe0q7y7CeoC/5RNKFrim31/jvWtCcPw/lPvlYPKQcVTIuElJrQgzta39bwIS4jCA7 rsfdcSSRfoSqEiRbfZjg8prfrSTdF0SWKgfwLYc1GtT173C/bopotIL/ASbArNqqX79S r6lAfE6W/wxBtfJfwMyxikYWy5fOa3IPtn4bqMTS2+QayI2XxohaJSbBGy9BZM3ZYXg5 YR3pkdoIWUXsIq1agtZ02LrhgcXWvgl7jq5yCxVVE7I5G87k1RknmWv/dM9rsYk18LTQ QIoiiah2gUUF4I0k/MonQB+1PmhHaYkB6f65D8/ZxbBYUvZafEqdhWOTI3xJ6HkJggLv jxTw== X-Forwarded-Encrypted: i=1; AJvYcCXxpJ2susZ/wVbEicufAfuzTardKe3gPWms+d2CsnS7FNaZgTs2K9zr9f44iQ/IXzGpGoBnI/1O6GZs7Vzhqw8ZngqWHaqJXq0R9Q== X-Gm-Message-State: AOJu0YzuLmZk+Ka51sdUj/Yk2Ja5/BrGvbm8Ea8LEvtoP3DlohTnPw+4 58UHHhOzFOvIpu6NlmzzdbPXv0pbtyTPFh1JYTeEEHaef7IHKOMXId037qGJTB2X4Ny0MW6zgNb C7WQfe4PVPAES4kNucy6skqdC+/FgVUyHMlN3rQ9To2pgwgVxP8GmSDyRTv4= X-Received: by 2002:a5d:558d:0:b0:34d:74cb:c0be with SMTP id ffacd0b85a97d-35526c569cbmr6656108f8f.35.1716846588277; Mon, 27 May 2024 14:49:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEeDSIRhyjR8f5YfNYD4UXo84TryBWhLWqV6JEglfmxyoZauncv6fTOlgBjCdXy0kuAEznp+A== X-Received: by 2002:a5d:558d:0:b0:34d:74cb:c0be with SMTP id ffacd0b85a97d-35526c569cbmr6656094f8f.35.1716846587707; Mon, 27 May 2024 14:49:47 -0700 (PDT) Received: from localhost (host86-153-169-45.range86-153.btcentralplus.com. [86.153.169.45]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3557a08d73fsm9900753f8f.25.2024.05.27.14.49.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 14:49:47 -0700 (PDT) From: Andrew Burgess To: Tom de Vries , gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] [gdb/symtab] Note success at debuginfod verbose level 2 In-Reply-To: <20240527141808.31563-3-tdevries@suse.de> References: <20240527141808.31563-1-tdevries@suse.de> <20240527141808.31563-3-tdevries@suse.de> Date: Mon, 27 May 2024 22:49:46 +0100 Message-ID: <87ikyz9b7p.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom de Vries writes: > Expand debuginfod verbose level 2 by also mentioning download successes: > ... > Downloading separate debug info for crc_mismatch-2...^M > Download succeeded: separate debug info for crc_mismatch-2.^M > Reading symbols from $client_cache/$hex/debuginfo...^M > ... LGTM. Approved-By: Andrew Burgess Thanks, Andrew > > Tested on x86_64-linux. > --- > gdb/debuginfod-support.c | 8 ++++++++ > .../gdb.debuginfod/build-id-no-debug-warning.exp | 2 ++ > gdb/testsuite/gdb.debuginfod/crc_mismatch.exp | 10 +++++++--- > 3 files changed, 17 insertions(+), 3 deletions(-) > > diff --git a/gdb/debuginfod-support.c b/gdb/debuginfod-support.c > index e65afb7523f..fe735756f72 100644 > --- a/gdb/debuginfod-support.c > +++ b/gdb/debuginfod-support.c > @@ -297,6 +297,14 @@ print_outcome (int fd, const char *desc, const char *fname) > desc, > styled_string (file_name_style.style (), fname)); > } > + if (fd >= 0 && debuginfod_verbose >= 2) > + { > + ui_file *outstream = get_unbuffered (gdb_stdout); > + gdb_printf (outstream, > + _("Download succeeded: %s %ps.\n"), > + desc, > + styled_string (file_name_style.style (), fname)); > + } > } > > /* See debuginfod-support.h */ > diff --git a/gdb/testsuite/gdb.debuginfod/build-id-no-debug-warning.exp b/gdb/testsuite/gdb.debuginfod/build-id-no-debug-warning.exp > index d63957ac05c..1f80dee9e33 100644 > --- a/gdb/testsuite/gdb.debuginfod/build-id-no-debug-warning.exp > +++ b/gdb/testsuite/gdb.debuginfod/build-id-no-debug-warning.exp > @@ -156,6 +156,8 @@ proc_with_prefix local_debuginfod { } { > [multi_line \ > "Reading symbols from ${build_id_debug_file}\\.\\.\\." \ > "Downloading separate debug info for ${build_id_debug_file}\\.\\.\\." \ > + [string_to_regexp \ > + "Download succeeded: separate debug info for ${build_id_debug_file}."] \ > "Reading symbols from ${cache}/\[^\r\n\]+\\.\\.\\.(?:\r\nExpanding full symbols from \[^\r\n\]+)*"] \ > "debuginfod running, info downloaded, no warnings" > } > diff --git a/gdb/testsuite/gdb.debuginfod/crc_mismatch.exp b/gdb/testsuite/gdb.debuginfod/crc_mismatch.exp > index 6dcabf60357..8391e8f4a01 100644 > --- a/gdb/testsuite/gdb.debuginfod/crc_mismatch.exp > +++ b/gdb/testsuite/gdb.debuginfod/crc_mismatch.exp > @@ -126,10 +126,14 @@ proc_with_prefix local_debuginfod { } { > > # CRC mismatch should not be reported now because the correct debuginfo > # should be fetched from debuginfod. > - gdb_test "file [standard_output_file crc_mismatch-2]" \ > + set binfile2 [standard_output_file crc_mismatch-2] > + gdb_test "file $binfile2" \ > [multi_line \ > - "Reading symbols from ${escapedobjdirsubdir}/crc_mismatch-2\\.\\.\\." \ > - "Downloading.*separate debug info for ${escapedobjdirsubdir}/crc_mismatch-2\\.\\.\\." \ > + [string_to_regexp "Reading symbols from $binfile2..."] \ > + [string_to_regexp \ > + "Downloading separate debug info for $binfile2..."] \ > + [string_to_regexp \ > + "Download succeeded: separate debug info for $binfile2."] \ > "Reading symbols from ${cache}/\[^\r\n\]+\\.\\.\\.(?:\r\nExpanding full symbols from \[^\r\n\]+)*"] \ > "debuginfod running, info downloaded, no CRC mismatch" > } > -- > 2.35.3