From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id 10E193858434 for ; Wed, 7 Feb 2024 15:44:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 10E193858434 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 10E193858434 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707320645; cv=none; b=YA+XdBemosMGeYcwKPufrlmlyO96k43FtpXVRmcIwfHCi16gqdRBH+em1nXTu+f12Nhp1TVv31WfOHRpn3Jhp5jhM6I1k+tHy9nYybFXIR6sIPYFSRci1YKZ1Zgi7gmPPZFuYDRCdWECaLm7i5/y95DWwfcIxDhDH0ZdGy1CkL8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707320645; c=relaxed/simple; bh=wr7vb/1NC3m11WRqOjRNSFz/U/zTeSfuIpeQK8LSffs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=lFR38XvL0Y9VNEWMrR+la1YPJTTgsy69x1yHIBy77U3s+3vE6fXD6zl2oJAEmDQLw0d+/ENvAZfkqwt0OVyvJCkkv7Q3EGW2y5BnGeNY0137+VkpZSDV/Bj/e7ba4sn/LNLB7Czy7zFKI9VFOECYyzaaGvECr1PHq1RNOaRn83E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6010a.ext.cloudfilter.net ([10.0.30.248]) by cmsmtp with ESMTPS id XebirqoGDAxAkXk5irTHrc; Wed, 07 Feb 2024 15:44:02 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Xk5hrdNbFGPGSXk5irkVmv; Wed, 07 Feb 2024 15:44:02 +0000 X-Authority-Analysis: v=2.4 cv=C+9KyhP+ c=1 sm=1 tr=0 ts=65c3a542 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=k7vzHIieQBIA:10 a=Qbun_eYptAEA:10 a=2rlLS1JVAAAA:8 a=zstS-IiYAAAA:8 a=xweabdwIQPx_T4ooydkA:9 a=-y79GXfwoCjg1VU16VqY:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Dq5I+OYvP5J0BBUDOH/s/ucQpvwq2xM+qiy8gu6Xwvo=; b=uYv2Ikdw0ZBJ8TX/kbiHebUKny GgVAHfRmqnCratfln0MFMDleJczuzGFG+JN1mpzRvwnzdBUIcMZfU8LO768He57lpiEAZjwMBuNtG VK/VzvzOOAcwYgJuFrRbD2IIR; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:45862 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rXk5h-002UBA-1Z; Wed, 07 Feb 2024 08:44:01 -0700 From: Tom Tromey To: Ciaran Woodward Cc: gdb-patches@sourceware.org, tom@tromey.com Subject: Re: [PATCH v2] Remove use of scoped_restore_tmpl from scoped_restore_warning_hook References: <20240206182213.23712-1-ciaranwoodward@xmos.com> <20240207111721.16314-1-ciaranwoodward@xmos.com> X-Attribution: Tom Date: Wed, 07 Feb 2024 08:44:00 -0700 In-Reply-To: <20240207111721.16314-1-ciaranwoodward@xmos.com> (Ciaran Woodward's message of "Wed, 7 Feb 2024 11:17:21 +0000") Message-ID: <87il30cm9r.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rXk5h-002UBA-1Z X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net (murgatroyd) [97.122.68.157]:45862 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHsk6uiTlUNKQk36K2G662edFf20Wd/BzYmbbyLYN2lyrkKjYspmC9hTMJNgBt4NY7hb/Me3GVSkEcY+gDbwJKhPjcs23HkRTJe/3MzaablAPV3eO4Ju r+LZMqhTJ+LV0ZFmer48MQ2IQ0TPM17gx9i1VAF2HwrYqxtV7TvjBpivWhivByC076YZZEYhe18ENiWd5krW8fEdolkN3LrJQGA= X-Spam-Status: No, score=-3016.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Ciaran" == Ciaran Woodward writes: Ciaran> The warning_hook_handler function pointer takes va_list as Ciaran> an argument, which on some platforms (mingw64) includes some Ciaran> attributes. Attributes get ignored in template arguments. Ciaran> This led to the compiler warning: Thanks for the patch. This is ok. Approved-By: Tom Tromey Tom