From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 3DFCC3858D33 for ; Tue, 6 Feb 2024 14:49:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3DFCC3858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3DFCC3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707230954; cv=none; b=I3FUxqC3Q4lAIiOMxev2+A1S/hkAhLAQzqAM6XauIgl1mhg2aggRGRVDsLduby5l9juZvZc2WuYDVurgt+GjLMGXS8HjsnPhDrW0m4Eo8k+VZ/gS4L7WKY+jHacrGMvViYh6a3fUVJi1VfsEqQ0EVlItQSy8k7VGH+x46XSsxx0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707230954; c=relaxed/simple; bh=P/34X3yk2uaHoPRB31AxRa+5YQuLrkt08Kj85HizRwI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=hlY8cEcTM1AWhnkoOxgf8BT1DnxaZ3nvkBPdw4z7G6j/Qj+cYU9I+Kd1O61xNtopnLR8bNnO+734wmPvUv1lJkv4zSr5OO4+CEw2e1mbgOH9XoqbCQhUJrTm/DQrl7PfKnSKCctSlKyguHvHboacZ0yPklmkyQePozyqmuqHU0M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6008a.ext.cloudfilter.net ([10.0.30.227]) by cmsmtp with ESMTPS id XLajrNJAmrh9zXMl4rVkwT; Tue, 06 Feb 2024 14:49:10 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id XMl3r6ZxdZLOPXMl3rQjVm; Tue, 06 Feb 2024 14:49:09 +0000 X-Authority-Analysis: v=2.4 cv=E75uprdl c=1 sm=1 tr=0 ts=65c246e5 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=k7vzHIieQBIA:10 a=Qbun_eYptAEA:10 a=2rlLS1JVAAAA:8 a=oNVc_wELEmDkj8dyq-kA:9 a=-y79GXfwoCjg1VU16VqY:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Ln049R4va26uy7AgKsQONLa7LSoVokfuIwGZOTyup7I=; b=RqnC0u/SwMY9kvCS1+5etBHydf 0hv/TuwN8/l8yBJra/i4xmFgbySq/NdONsXE8FlRrHnCUPfAL4IyHlKfXbgQdhJQKeNuNd54y+1Xj Rk7GvtGoodkcE4LOxO4J+EQAt; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:37100 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rXMl3-002rGp-0D; Tue, 06 Feb 2024 07:49:09 -0700 From: Tom Tromey To: Ciaran Woodward Cc: Aditya Kamath1 , Tom Tromey , Ulrich Weigand , Sangamesh Mallayya , Aditya Kamath1 via Gdb-patches Subject: Re: [PATCH] Fix AIX build break. References: <20240117182831.74066-1-Aditya.Kamath1@ibm.com> <87o7djn4nh.fsf@tromey.com> <875xzpmgtd.fsf@tromey.com> <87plxpqjeb.fsf@tromey.com> <878r46pc71.fsf@tromey.com> <87le85nhnt.fsf@tromey.com> X-Attribution: Tom Date: Tue, 06 Feb 2024 07:49:07 -0700 In-Reply-To: (Ciaran Woodward's message of "Tue, 6 Feb 2024 12:36:42 +0000") Message-ID: <87il31ejh8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rXMl3-002rGp-0D X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net (murgatroyd) [97.122.68.157]:37100 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOHHCg4suzycST0/Edr4zSHhIN4lkx/mLaQogwYTQVKz8PH43IKUzkp8we0wTmkZ0rKO3CK6k/LnO847GMp8/RX/3YCMo1WPVqR8yKJ9i9B6o2J4oO8Q BEBspqE5FEGfJAQHPtqk0zymEIww0btk6+n2K/4ECkNaTpa0NVmITx3zMia93FzUquvnhrPWiUJlAA2qCT0l/iMzTBbW6oVr+4s= X-Spam-Status: No, score=-3016.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Ciaran" == Ciaran Woodward writes: Ciaran> I think it is because va_list on that platform has some attributes. Ugh. Ciaran> scoped_restore_warning_hook::scoped_restore_warning_hook Ciaran> (warning_hook_handler new_handler) Ciaran> - : m_save (make_scoped_restore (&warning_hook, new_handler)) Ciaran> + : m_save (make_scoped_restore (reinterpret_cast(&warning_hook), Ciaran> + reinterpret_cast(new_handler))) What if we remove the scoped_restore use and just do the save/restore manually here instead? Tom