From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id BF2D53858407 for ; Thu, 11 Jan 2024 21:14:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BF2D53858407 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BF2D53858407 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705007655; cv=none; b=kslGBwz52Jlg0zvdDrIaGuHHlPULvPsBGgy+If/l3+5W+OqLLjfZLyMbBN3l3HUGZvNZb+BJVWXsyyShzzWBjmR8yOFZxOnbsfaod8HEEKZ9nJpwB8Q3YkEo1NQCxTfeuuUSe+l2iWuUc0UD2FwZoRw54RIsXlw/4h5P24jPWz0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705007655; c=relaxed/simple; bh=1mqCt/SLqwYZZZ54xjTwaPfY/QbjXQd0uQ6f6lPpPYc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=omAQwha67LI8kC0Vk2FeNwFmNjuP1DIRjBXdVLID6Or3mX+8eAC4CYog3fGSKPMSAf8ls2GM0do3I1pQ7AGmng/b/QTtOvUwjL2Z+sqOgO2cRyhVLAPzV5c/AOsFfEcJoetu/s0DTAhNTGoxQ4dIlJZlrHWdKn46rjHpxq+laHM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5003a.ext.cloudfilter.net ([10.0.29.159]) by cmsmtp with ESMTPS id NvbIrkypOMVQiO2NPrEEdY; Thu, 11 Jan 2024 21:14:11 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id O2NOrIagWl5UwO2NOrgOuz; Thu, 11 Jan 2024 21:14:11 +0000 X-Authority-Analysis: v=2.4 cv=daKTYFbe c=1 sm=1 tr=0 ts=65a05a23 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=dEuoMetlWLkA:10 a=Qbun_eYptAEA:10 a=zstS-IiYAAAA:8 a=fXzP6BZeWlDpG-jPyhAA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cpQj+0WYQ3hfyiEcraNW+Zhx0DnEsONFdEKRdjj+798=; b=hg8z6t5yDmyTMmgXrxeVKSNwaC n6X6g3zEf0y4bJqBC1v/05rfmotOoDpdlSS1btNCMbCn+dE3Ejk2axOkuKTsH/QP7Zfe/WD+xIneA dTOPyrBo/1TaE85XLTBLu47Vq; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:57140 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rO2NN-002WOY-38; Thu, 11 Jan 2024 14:14:10 -0700 From: Tom Tromey To: Toby Lloyd Davies Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/python: Fix segfault when iterating over empty linetable References: <20240111162340.282041-1-tlloyddavies@undo.io> X-Attribution: Tom Date: Thu, 11 Jan 2024 14:14:08 -0700 In-Reply-To: <20240111162340.282041-1-tlloyddavies@undo.io> (Toby Lloyd Davies's message of "Thu, 11 Jan 2024 16:23:40 +0000") Message-ID: <87il3zpo7z.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rO2NN-002WOY-38 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net (murgatroyd) [97.122.68.157]:57140 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFj++ve26sjTuOOQPDJTewAB7KkvzAr8+rW+nFt1BR+22Rnc0RkJ/z+7VaNpV5bZyfcgjIZxNhBAavg6WMQwyNbqm+ZFIkaYVF9gxKH/MGHyqCl/U9e8 0aI7NdZ/lqCxqYHeexfNdXVYlAMVMMEtsc1/44VD7kr//B3WvBVixskrgE7BOSKj4QDKQfUc919nA0/dgLaWOnsz/bnR5ww6hKA= X-Spam-Status: No, score=-3016.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Toby" == Toby Lloyd Davies writes: Toby> symtab->linetable () is set to null in Toby> buildsym_compunit::end_symtab_with_blockvector () if the symtab has no Toby> linetable. Attempting to iterate over this linetable using the Python Toby> API caused GDB to segfault. Thank you for the patch. This is ok. Approved-By: Tom Tromey Tom