public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Hannes Domani <ssbssa@yahoo.de>
Cc: Tom Tromey <tom@tromey.com>,
	 "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Use function entry point record only for entry values
Date: Fri, 15 Dec 2023 17:32:03 -0700	[thread overview]
Message-ID: <87il4z56nw.fsf@tromey.com> (raw)
In-Reply-To: <1999418578.1773937.1702535399232@mail.yahoo.com> (Hannes Domani's message of "Thu, 14 Dec 2023 06:29:59 +0000 (UTC)")

>>>>> "Hannes" == Hannes Domani <ssbssa@yahoo.de> writes:

Hannes> Yes, it is about optimization.
Hannes> I should have added more context, since I was even talking about
Hannes> 2 different examples.
Hannes> If I change the commit message to the following, maybe the
Hannes> behavior is more clear:

Thank you.  I re-read the code and your description, and I think it is
clear now.

Hannes>   Range 0x13fd41600-0x13fd41600: the constant 1

... the start==end case is the sign that this is an entry value, IIUC.

Anyway I think your patch is ok.
Approved-By: Tom Tromey <tom@tromey.com>

Tom

  reply	other threads:[~2023-12-16  0:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20231207124745.1362-1-ssbssa.ref@yahoo.de>
2023-12-07 12:47 ` Hannes Domani
2023-12-13 17:39   ` Guinevere Larsen
2023-12-13 20:48   ` Tom Tromey
2023-12-14  6:29     ` Hannes Domani
2023-12-16  0:32       ` Tom Tromey [this message]
2023-12-16 10:29         ` Hannes Domani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87il4z56nw.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ssbssa@yahoo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).