From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 33666385802A for ; Tue, 12 Dec 2023 18:39:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 33666385802A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 33666385802A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702406394; cv=none; b=xSFlY8egdbDLCNiG0TbCcCu5A/S1sUVnbN8nDyZbLgab3QEbY0HahemFsIAPNY2n14u675yrRkTta2BAuHXELa/jqEhs1HyZNziNylnpUhf3A5CbOq6ThIzHfwlUFeB86i8KXqdQ2VqF5aSTcQzI7hCYJ7jlPV5TbSM3fAWJexA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702406394; c=relaxed/simple; bh=MeyaQz85+1eR9g5g+SjMWJf3PVm5h+choRd0bUQ3vJQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=uSQYpqFfAuSXoJiuPOnazJW3gIxqthqFeal9PNmlUsNmSpNjJvUK3QENlSvDTY6APaX2DGu0nlKAxOUHuqPNdfsRO/Ph+mnEegZ/HEezUPUBhF69zdHU59JQC7oQi/DGpE+k7p1UpEGFYakGA0dE1KlVfl//ci7vLK5rDWVuvQk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5002a.ext.cloudfilter.net ([10.0.29.215]) by cmsmtp with ESMTPS id D70jrEXDx8HteD7farSIa4; Tue, 12 Dec 2023 18:39:51 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id D7fZrh92IRQmiD7fZrvWXK; Tue, 12 Dec 2023 18:39:50 +0000 X-Authority-Analysis: v=2.4 cv=CdcbWZnl c=1 sm=1 tr=0 ts=6578a8f6 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=H3ReeFWlWpdJ01r5F84A:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=raENzUdIv6OVTMq7r2Kd3/T0qDrArU7RYOn44/d022k=; b=uJ6+iStGxpE5qw7X5NWP66tzBg Leh062NX+XntzW1LMcPzN/Jo9tSxRsC07F1cWqpDTC4kp7AeYPiDUsPZVKEaD0K2C133yMvOzCEKm rl7febde9/T/yxp+fL8l0Yu8n; Received: from 71-211-161-25.hlrn.qwest.net ([71.211.161.25]:41766 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rD7fZ-001P58-0m; Tue, 12 Dec 2023 11:39:49 -0700 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 04/13] [gdb/symtab] Factor out m_deferred_entries usage References: <20231212173239.16793-1-tdevries@suse.de> <20231212173239.16793-5-tdevries@suse.de> X-Attribution: Tom Date: Tue, 12 Dec 2023 11:39:48 -0700 In-Reply-To: <20231212173239.16793-5-tdevries@suse.de> (Tom de Vries's message of "Tue, 12 Dec 2023 18:32:30 +0100") Message-ID: <87il53cljf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.161.25 X-Source-L: No X-Exim-ID: 1rD7fZ-001P58-0m X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-161-25.hlrn.qwest.net (murgatroyd) [71.211.161.25]:41766 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHBKnjo2in2e55CKhQYvzP4xtF6VYRo5CNg840TBxoPqvcWjBbuJH8UILxiCRds5JP00YCzndq37Nq/5/N6HxOGZJopVDNWc4NMSPWSERewCdeTX5jME P6McmraFwozQbzRpo5weA/UhmAGWoLKssXrtQ88GFnNvFAFl9F03GePd8PKYnYNJzYFM3PQMRUnCFgKgBP9qaucilE66qPpyDPU= X-Spam-Status: No, score=-3017.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> Factor out usage of cooked_indexer::m_deferred_entries in new member Tom> functions defer_entry, handle_deferred_entries and resolve_deferred_entry. I don't mind this, but when reading through the whole series, it seems like the code has to now iterate over a lot of the entries trying to fix up the parentage later. I wonder then about just sticking this info directly into the cooked_index_entry object, and then doing fixups directly on these in the shard. That is, instead of keeping separate "deferred" entries, just making ordinary entries. cooked_index_entry::parent_entry could be a union holding either the parent (if known) or a CORE_ADDR; and then there could be a new flag in cooked_index_flag_enum indicating which one is in use. Then I think parent_map::deferrred also would not be needed. I'm still kind of mid-reading so my apologies if this doesn't really make sense. Tom