From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 1936C3858D37 for ; Tue, 5 Dec 2023 20:59:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1936C3858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1936C3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701809983; cv=none; b=ScrVV80si5Ggxy/JQpgAYX1j6LQ1rHMr/Lafc8IusvSqcKchB6OtSFMYpop4zYMlCljQczKea3jDcLR3n3jOtsfKIhYNlch/5V2EuVK+9chMonM8XcDQ4ReS8i/AFAFUvGsR1I2PRQFqGVByfUry3IJRQ4HsP0tPtn2B9SD2Alk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701809983; c=relaxed/simple; bh=M2J7f4tmIgb824VZ+tzjWXI563RPKGI9qgjGntQgUis=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=eEZrb6NqTCQg9mIlr5+ozvCNKRVnc0eGzZURhdcsKwhSa01yQl/ER8K3GEezhQD7DIlLPd02yab/xRdwDzFq7D0pP1zrenuBG4ZQNdqa6qxQNAgwxbgjC7MwoYXtifgH6wLrrnOc0Mr2ybp1qHIVf2OmbUz679KDhWNh0lEru0I= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5002a.ext.cloudfilter.net ([10.0.29.215]) by cmsmtp with ESMTPS id Ab85rYuzdgpyEAcW4rTruz; Tue, 05 Dec 2023 20:59:40 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id AcW3rpPbURQmiAcW3rKErh; Tue, 05 Dec 2023 20:59:39 +0000 X-Authority-Analysis: v=2.4 cv=CdcbWZnl c=1 sm=1 tr=0 ts=656f8f3b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=xVzXA_MOKzjXvJzQLBkA:9 a=zZCYzV9kfG8A:10 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zjvCwYnBILfJ6FbJlUJ9atjeg2hi+0mBVk75R4EQ1ak=; b=wLzTRwEpRMYzt/+tp4fhYi6C+H Sh+MgcrAG5Xbft0lvRrxIvVVFxMQ+2x93WLskfio2E2V8ilwQ1oMNDsboMHWx0LaxW10URuKfYv4f li1giKgmgVJh+aikh5qRDEbhp; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:45944 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rAcW3-001ETt-06; Tue, 05 Dec 2023 13:59:39 -0700 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH][gdb/symtab] Redo "Fix assert in set_length" References: <20220922130015.GA25067@delia.home> X-Attribution: Tom Date: Tue, 05 Dec 2023 13:59:38 -0700 In-Reply-To: <20220922130015.GA25067@delia.home> (Tom de Vries via Gdb-patches's message of "Thu, 22 Sep 2022 15:00:22 +0200") Message-ID: <87il5cjrgl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1rAcW3-001ETt-06 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (murgatroyd) [97.122.77.73]:45944 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFvJsXKVfL0XqFQ3aJCfSgxtQgcAPhE0E1DLm+4IE7/QStQB0oEevtdmihBWwgbJ8D+O38zO377uGiHlF/UpVCgWCF/nJSjAe4Ok9UrfYlocV9BiJRGc sPRLcmPH80A0DA4HhpHnYM2cNDu6ATzgWLZMdMpAqi/INKLmPub0X8y8vWrziRvLtczVQn6kWxMnhx6ZUYKR1ANAwx/AX++CzpA= X-Spam-Status: No, score=-3017.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> Hi, Tom> This reverts commit 1c04f72368c ("[gdb/symtab] Fix assert in set_length"), due Tom> to a regression reported in PR29572, and implements a different fix for PR29453. Tom> The fix is to not use the CU table in a .debug_names section to construct Tom> all_comp_units, but instead use create_all_comp_units, and then verify the CU Tom> table from .debug_names. This also fixes PR25969, so remove the KFAIL. Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29572 Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=25969 Tom> Any comments? I've come around on this patch and I think you should check it in. My main concern was the time cost, but you showed that this isn't important; and anyway gdb is probably going to map these sections and do more stuff with them later anyhow. So, I think you should check this in. Approved-By: Tom Tromey Tom