From: Tom Tromey <tom@tromey.com>
To: "Bouhaouel, Mohamed" <mohamed.bouhaouel@intel.com>
Cc: Tom Tromey <tom@tromey.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"blarsen@redhat.com" <blarsen@redhat.com>,
"eliz@gnu.org" <eliz@gnu.org>
Subject: Re: [PATCH v3 3/3] gdb, zpoint: check for target hardware breakpoint support
Date: Fri, 17 Nov 2023 06:42:28 -0700 [thread overview]
Message-ID: <87il60lcmz.fsf@tromey.com> (raw)
In-Reply-To: <DM6PR11MB44574000A4080576983BDFE8E4B1A@DM6PR11MB4457.namprd11.prod.outlook.com> (Mohamed Bouhaouel's message of "Wed, 15 Nov 2023 18:18:20 +0000")
>>>>> Bouhaouel, Mohamed <mohamed.bouhaouel@intel.com> writes:
>> > + /* If hw read watchpoints are not supported while hw access are,
>> > + GDB will try to insert the watchpoint as hw access. */
>> > + bool access_support = supports_z_point_type (
>> > + bptype_to_target_hw_bp_type (bp_access_watchpoint));
>>
>> Formatting looks wrong here.
> Hmm, how else can we format it? One suggestion is to use an additional variable
> to store the return of " bptype_to_target_hw_bp_type (bp_access_watchpoint)".
Yeah, that would work. A dangling open paren isn't really gdb style.
Another way would be
bool access_support
= (supports_z_point_type
(bptype_to_target_hw_bp_type (bp_access_watchpoint)));
kind of uglier than a new variable but it's done elsewhere.
Tom
prev parent reply other threads:[~2023-11-17 13:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 13:35 [PATCH v3 0/3] Check for zpoint support when handling watchpoints Mohamed Bouhaouel
2023-11-14 13:35 ` [PATCH v3 1/3] gdb, gdbserver, zpoint: report z_point support Mohamed Bouhaouel
2023-11-14 13:45 ` Eli Zaretskii
2023-11-14 14:36 ` Tom Tromey
2023-11-15 17:31 ` Bouhaouel, Mohamed
2023-11-14 13:35 ` [PATCH v3 2/3] gdb, breakpoint: add a breakpoint type converter Mohamed Bouhaouel
2023-11-14 14:37 ` Tom Tromey
2023-11-15 17:44 ` Bouhaouel, Mohamed
2023-11-14 13:35 ` [PATCH v3 3/3] gdb, zpoint: check for target hardware breakpoint support Mohamed Bouhaouel
2023-11-14 14:45 ` Tom Tromey
2023-11-15 18:18 ` Bouhaouel, Mohamed
2023-11-17 13:42 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il60lcmz.fsf@tromey.com \
--to=tom@tromey.com \
--cc=blarsen@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=mohamed.bouhaouel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).