From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 036E73858C78 for ; Fri, 17 Nov 2023 13:42:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 036E73858C78 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 036E73858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700228555; cv=none; b=nR20+KxyGn+s6xJJL2/Y7YVoxWBsBxIdrt94ZJOMVHohbwHnK4MFYhfajKmijQZEK8Ss6waf9ThuDbriCou97mTnh/v/czt6pT7xCHM/WW8W6keHyOthgG0GpSqXhXvOaLENicT3qXKTgCLQg8Upfgt03+yyc/6YDS4TyCID4Hs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700228555; c=relaxed/simple; bh=8tTLJql609UR2BR4g7pTOsfF2CmZ/mwoOXDz54QfC0M=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=vYtQQDNFzqzMzDezan4fA9H9974s8fp3yOHJ2TXW/IRA8oA8bGK1ToEx4qL2oKMRMQV2D2D03GjzVY6axtbfUA6yxcnPS3Aj6ZkgABzZPsL4MdwU1tB7LqiZVFLbbvmCxpxFk3c/3fdsFtu1/JxNu9clyhL9rYZ8bm2W+xk7ZUI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5006a.ext.cloudfilter.net ([10.0.29.179]) by cmsmtp with ESMTPS id 3jzNrAziN8Hte3z79rptZn; Fri, 17 Nov 2023 13:42:31 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 3z78rtU801J283z78rfIbW; Fri, 17 Nov 2023 13:42:30 +0000 X-Authority-Analysis: v=2.4 cv=Tqz1ORbh c=1 sm=1 tr=0 ts=65576dc6 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=BNY50KLci1gA:10 a=Qbun_eYptAEA:10 a=QyXUC8HyAAAA:8 a=uhbP66uU68Kk-f-q-koA:9 a=zZCYzV9kfG8A:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Z9qxCv0V8kw+0ie6JTV9M9saCdQnRYbcycJDSnHZKCQ=; b=HZzYapTsFtRp8oBp++5RlKRcAn vXyE6gBRxv/HuB2CQ6iNBjxNLsacsla+UuXYJz3WScvFZGjYrYPG1vzbv9SneW3VL75MRqLR+Pypp zL7YziaoHybbrudaQ67AQHk9i; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:47204 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1r3z77-0048D6-2L; Fri, 17 Nov 2023 06:42:29 -0700 From: Tom Tromey To: "Bouhaouel, Mohamed" Cc: Tom Tromey , "gdb-patches@sourceware.org" , "blarsen@redhat.com" , "eliz@gnu.org" Subject: Re: [PATCH v3 3/3] gdb, zpoint: check for target hardware breakpoint support References: <20231114133532.3877-1-mohamed.bouhaouel@intel.com> <20231114133532.3877-4-mohamed.bouhaouel@intel.com> <878r70qtqe.fsf@tromey.com> X-Attribution: Tom Date: Fri, 17 Nov 2023 06:42:28 -0700 In-Reply-To: (Mohamed Bouhaouel's message of "Wed, 15 Nov 2023 18:18:20 +0000") Message-ID: <87il60lcmz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1r3z77-0048D6-2L X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (murgatroyd) [97.122.77.73]:47204 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfKi5Zbz/Et/H4ZMwVEWs+EDo8djDeJZEkLYOF4FcHlYCz0Ko4MSxL/fe9Gh4T8VVHCKLm6nQOCewe86V5hFsSlVye23qMOorij5Ej/4JOfWQCDyoRgGp x+quvUKEQAz1V3SuSu5hbTMUjrje+JSo0hUfRvqcvz571eUIQFv7Wizl9y0qvJlVJtNJ484c0CtOx0DolXLoS0ROTdIvCXathC8= X-Spam-Status: No, score=-3018.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Bouhaouel, Mohamed writes: >> > + /* If hw read watchpoints are not supported while hw access are, >> > + GDB will try to insert the watchpoint as hw access. */ >> > + bool access_support = supports_z_point_type ( >> > + bptype_to_target_hw_bp_type (bp_access_watchpoint)); >> >> Formatting looks wrong here. > Hmm, how else can we format it? One suggestion is to use an additional variable > to store the return of " bptype_to_target_hw_bp_type (bp_access_watchpoint)". Yeah, that would work. A dangling open paren isn't really gdb style. Another way would be bool access_support = (supports_z_point_type (bptype_to_target_hw_bp_type (bp_access_watchpoint))); kind of uglier than a new variable but it's done elsewhere. Tom