From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id 9B3E03858426 for ; Fri, 6 Oct 2023 20:41:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9B3E03858426 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-6910ea9cddbso2182575b3a.0 for ; Fri, 06 Oct 2023 13:41:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696624913; x=1697229713; darn=sourceware.org; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=M0GlNahiIsDQYbGQKbk9SVdibLvxCptEyIJLjSM9ddg=; b=o2OlEc0j50uAzybvbE9aPa4HINm4rvdbA+a1ZUwbywWkZhCnlw0KwkDxJ2s3g7KNRo dyi27MMlkeEKLI/yBGg7rAozPtq/EXkLcSie1U2X5sLmVTk3GSEwK8TzHNWz/oWCHm7H vg6Uw1HKaYob2ICRZrN53OnTmBsApT5lId0rLBqyRSwXSIwopaudxSEG44V9rkTCy/yS KBQYhn5leveM1tk1sw+8xGFc2LbnpL2VODafhvAKzcOEtYdO9EvOEuumY/3l4fDs2EC0 VO54aJ+wjwZbDzhOvM+9EWytheHGBqB6hsN5aWU+FV6jdaIxTKwpSAwGzKjyYVoH7jbF ZmKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696624913; x=1697229713; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M0GlNahiIsDQYbGQKbk9SVdibLvxCptEyIJLjSM9ddg=; b=CrFnQI5vgWgF+nW4vcMj0uZUUE1twdfWZapSHQuSlcNGUxY5Esp/+UDZ/pOMs3NNs3 QnjzB/0BMITYk7FE6YQiiIaXpZBOEG4e5jzGf9N0PgSEtVWlzvExi9FnPA3HXXl91sNu IttL6i20iZ4KYQpUErynh+YMmfNjJjlUASZB9hh0F8Z8uRyM2762deC4DE4TvmdpZ4KF qwvrHhP/HU5Nru2XoH7rLb9QutwY2qiusK4Kfh4MCqRGr49YCacJFA24Va1+zc1lZf+p 7Gk9usVKAsIpIsK09T4PGaz47KoJiaNLAvarV5LMx4PNJM1P8KD42C3O8S5ZOXFMD68L grEw== X-Gm-Message-State: AOJu0YwG1gihadd43dKherw3j91D0XrkPnvIWn40/UiMZWWocv/yX4Pz 4cxCzKcyEQ5JM3XkhN1FLKbuyQ== X-Google-Smtp-Source: AGHT+IGYbJCCeKh0im+KYpujVAjEmEkEneZqXCBllWhHcpe0tLpU1qqAZEj9Tb9u27WHaHTjnDlNKw== X-Received: by 2002:a05:6a00:1989:b0:68f:e121:b37c with SMTP id d9-20020a056a00198900b0068fe121b37cmr10692522pfl.4.1696624913574; Fri, 06 Oct 2023 13:41:53 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:927f:3b0e:b309:6a0a]) by smtp.gmail.com with ESMTPSA id j3-20020aa79283000000b0066a4e561beesm1981675pfa.173.2023.10.06.13.41.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 13:41:52 -0700 (PDT) References: <20230929175313.24845-1-thiago.bauermann@linaro.org> <87sf6nsmtz.fsf@redhat.com> User-agent: mu4e 1.10.7; emacs 29.1 From: Thiago Jung Bauermann To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] process-dies-while-detaching.exp: Exit early if GDB misses sync breakpoint In-reply-to: <87sf6nsmtz.fsf@redhat.com> Date: Fri, 06 Oct 2023 17:41:50 -0300 Message-ID: <87il7jlbzl.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Andrew Burgess writes: > Thiago Jung Bauermann via Gdb-patches > writes: > >> I'm seeing a lot of variability in the failures of >> gdb.threads/process-dies-while-detaching.exp on aarch64-linux. On this >> platform, a problem yet to be investigated causes GDB to miss the _exit >> breakpoint. What happens next is random because after missing that >> breakpoint, GDB is out of sync with the inferior. This causes the tests >> following that point in the testcase to fail in a random way. >> >> In this scenario it's better to exit the testcase early to avoid random >> results in the testsuite. >> >> We are relying on gdb_continue_to_breakpoint to return the result of >> gdb_test_multiple. This is already the case because in Tcl the return >> value of a function is the return value of the last command it runs. But >> change gdb_continue_to_breakpoint to explicitly return this value, to make >> it clear this is the intended behaviour. >> >> Tested on aarch64-linux. > > Looks great. Thanks for improving this. > > Approved-By: Andrew Burgess Thank you! Pushed as commit 0f3efefb34f8. -- Thiago