From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 53DD43857B9B for ; Thu, 14 Sep 2023 16:17:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 53DD43857B9B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from eig-obgw-5007a.ext.cloudfilter.net ([10.0.29.141]) by cmsmtp with ESMTP id gZm7qMi0qyYOwgp1qqp8gp; Thu, 14 Sep 2023 16:17:19 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id gp1pqwQ4dfgbSgp1qqIBpk; Thu, 14 Sep 2023 16:17:18 +0000 X-Authority-Analysis: v=2.4 cv=S/PKfagP c=1 sm=1 tr=0 ts=6503320e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=zNV7Rl7Rt7sA:10 a=Qbun_eYptAEA:10 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=y26Bvzfj-3c2TpXgXE0A:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kmmLkKy5/kPSVV28y+T26l2TjGrX7mnDJf6T28/HLaQ=; b=F87cYTjG1EFz5n6Ho1B5Tk4V7a x7tB88JOBJj2gos82nNt9QnEvhDDtnrBoR4OrnfYgkyd2AkLbHZ4QIQJv4FARvKYEQKENxn/cPc8T nDUIRcCACHldyLachnW40WMd2; Received: from 71-211-130-31.hlrn.qwest.net ([71.211.130.31]:35388 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qgp1p-003ZYJ-1b; Thu, 14 Sep 2023 10:17:17 -0600 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess Subject: Re: [PATCH] gdb: small cleanup in symbol_file_add_with_addrs References: <6219a1ae148c0b9796f7153b9a6c3b7173fb8f5a.1694706545.git.aburgess@redhat.com> X-Attribution: Tom Date: Thu, 14 Sep 2023 10:17:16 -0600 In-Reply-To: <6219a1ae148c0b9796f7153b9a6c3b7173fb8f5a.1694706545.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Thu, 14 Sep 2023 16:49:29 +0100") Message-ID: <87il8chgqb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.130.31 X-Source-L: No X-Exim-ID: 1qgp1p-003ZYJ-1b X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-130-31.hlrn.qwest.net (murgatroyd) [71.211.130.31]:35388 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHxdCkw2YNmMfo+3P4a2U/yZ+HLu8EdHd/8U3MjhQYGKdGJ9Z824yem9E0RQ/vORA/KXZN/vb1G/3nAY9MkRAFYImvvTNQ671AQdLloDXf+kYh0ovA4M lWs30v/qg+NeO+RgfmYTrnGpaUTd2+vkjBf9EyhlY19oPNaHUxTNuD7La/yKE4J95irCxcdDLSwmu9mMwJjdr9bUpV04uNo5YBk= X-Spam-Status: No, score=-3015.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> I'm not sure how this change could be tested, I don't believe there's Andrew> any GDB (maintenance) command that displays the BFD cache contents, so Andrew> we can't check the cache contents easily. Ideas are welcome though. Also, the cache isn't really inspectable without reaching into BFD internals. This patch looks good to me. Approved-By: Tom Tromey Tom