From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9095E3858D3C for ; Tue, 12 Sep 2023 10:41:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9095E3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694515263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wwm/qZvwB5TgmqSvHY8tmxsH2lnDij6S3qTdofWrCIY=; b=O09xfDjMY9m2fsJsjfYyK/IjctK4+OTUZIoS+E42yHgbQ7mJE9/MXcGny6lmM2n9cD+Y4X WqWFM1gkn/AApBoJSx1FrQLsTo0DWtKwIfYE7vCuCLY6TtIPZwQSl3XwBK/jtPLgXU9NXj L5FEZD7YIIgKMt0h6PHYvUcRF0DPYVA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-443-iMs_YwuHNka8TshyXJdw9g-1; Tue, 12 Sep 2023 06:41:02 -0400 X-MC-Unique: iMs_YwuHNka8TshyXJdw9g-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-401d8873904so43869305e9.0 for ; Tue, 12 Sep 2023 03:41:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694515261; x=1695120061; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wwm/qZvwB5TgmqSvHY8tmxsH2lnDij6S3qTdofWrCIY=; b=mVmAS1i7jQEAO7vpfLKaQrmwAEeiQpm6edz866yjzcrh8zLIBSHafA05jj7dFf9fmx ehESOy9Fj3qNHcu7U2hKeVByAW5ZNE26cL36baMZ5bvWmXxxqmKHyg9eCwu0FW6KRQKF N9LTpoB//yEAtC1qtE+v8ib8hA43ixR1Y4nyLFOgzn+E9uD8UVQn6WNyoQ2tpj45nnT7 2O7M8csLCjwLCyHxM4ggMm1V4aiIvdgzc2cXYmInQ1RZ539ssqBql2QpCDFt6YKrimRP 1CcE1XbyOVSEJgsveRd39sUjRzPW7pK+t5+3YeQINaawqykRVjRh/ft3D9wvLiIjJF74 yimA== X-Gm-Message-State: AOJu0YwAGG8puxKBRgTJOJqcOl3/nnKx3K0pIEIb1Mn4IzxZ5xT0xn/M 7xC58T6csgwD1HJNQtbZleA2D1/7vKyVq0puJcD+9loWUIppVJkDRDxhgtIe5chgpniwvj9zi05 2/W7w4mxts7KO1i6sZIGDsejiea0yVg1cuTzq3DdXz0c+TE6x73S47IaH4taKvpeqfeVnMshwic 0L9Mj2aQ== X-Received: by 2002:a05:600c:600c:b0:403:af4:3178 with SMTP id az12-20020a05600c600c00b004030af43178mr5834061wmb.1.1694515260810; Tue, 12 Sep 2023 03:41:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHhrq/796DEDMdd03he6JFsWtx1F8iVscy6k4RlSJguGAXUIpw3B6c8IAa3gAQqtxE1IZiHNA== X-Received: by 2002:a05:600c:600c:b0:403:af4:3178 with SMTP id az12-20020a05600c600c00b004030af43178mr5834045wmb.1.1694515260353; Tue, 12 Sep 2023 03:41:00 -0700 (PDT) Received: from localhost (197.126.90.146.dyn.plus.net. [146.90.126.197]) by smtp.gmail.com with ESMTPSA id d21-20020a1c7315000000b00400268671c6sm12416927wmb.13.2023.09.12.03.40.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 03:41:00 -0700 (PDT) From: Andrew Burgess To: Simon Marchi via Gdb-patches , gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 11/21] gdb/cli: use m_ui instead of current_ui in cli_interp::resume In-Reply-To: <20230908190227.96319-12-simon.marchi@efficios.com> References: <20230908190227.96319-1-simon.marchi@efficios.com> <20230908190227.96319-12-simon.marchi@efficios.com> Date: Tue, 12 Sep 2023 11:40:58 +0100 Message-ID: <87il8fk72d.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon Marchi via Gdb-patches writes: > No behavior changes expected. > > Change-Id: I7fd944c99d249b3080d74d949186fe92795568eb > --- > gdb/cli/cli-interp.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/gdb/cli/cli-interp.c b/gdb/cli/cli-interp.c > index f0fa26919e76..8f1dbef56a6e 100644 > --- a/gdb/cli/cli-interp.c > +++ b/gdb/cli/cli-interp.c > @@ -190,25 +190,22 @@ cli_interp::init (bool top_level) > void > cli_interp::resume () > { > - struct ui *ui = current_ui; > - struct ui_file *stream; > - > /*sync_execution = 1; */ > > /* gdb_setup_readline will change gdb_stdout. If the CLI was > previously writing to gdb_stdout, then set it to the new > gdb_stdout afterwards. */ > > - stream = m_cli_uiout->set_stream (gdb_stdout); > + ui_file *stream = m_cli_uiout->set_stream (gdb_stdout); In the previous patch you changed an explicit reference to gdb_stdout to m_ui->stdout (). It's not clear why you haven't done that here, and in other places in this function. Thanks, Andrew > if (stream != gdb_stdout) > { > m_cli_uiout->set_stream (stream); > stream = NULL; > } > > - gdb_setup_readline (ui, 1); > + gdb_setup_readline (m_ui, 1); > > - ui->input_handler = command_line_handler; > + m_ui->input_handler = command_line_handler; > > if (stream != NULL) > m_cli_uiout->set_stream (gdb_stdout); > -- > 2.42.0