From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 44FAB3857B98 for ; Thu, 10 Aug 2023 16:28:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 44FAB3857B98 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id 7B29D10047E36 for ; Thu, 10 Aug 2023 16:28:47 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id U8WlquFOfbpcgU8WlqSgs0; Thu, 10 Aug 2023 16:28:47 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=bKDTnNyZ c=1 sm=1 tr=0 ts=64d5103f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=75FAf6A6GYzAqeeAwkAA:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hWy0Uix2NeBe6hHX/BYVnohZNghpfajosJumXpBSl0Y=; b=DTuSQnVEhEK7TLIsIbdQRTkMVn qjS2Hz+8C8dQwhM4THEKBxAQPjuRgAXtAPQH/FT/cyzO1cj1hC7h+S3lPS+kk25Nf13y7yj0XhW2x 40gP8m9Vv1u8xMYPqCdPRze20; Received: from 71-211-152-221.hlrn.qwest.net ([71.211.152.221]:33190 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qU8Wl-000vZd-0m; Thu, 10 Aug 2023 10:28:47 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries , Tom Tromey Subject: Re: [PATCH] [gdb/symtab] Fix off-by-one error in cooked_indexer::recurse References: <20230809150857.22557-1-tdevries@suse.de> X-Attribution: Tom Date: Thu, 10 Aug 2023 10:28:46 -0600 In-Reply-To: <20230809150857.22557-1-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Wed, 9 Aug 2023 17:08:57 +0200") Message-ID: <87il9m3lq9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.152.221 X-Source-L: No X-Exim-ID: 1qU8Wl-000vZd-0m X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-152-221.hlrn.qwest.net (murgatroyd) [71.211.152.221]:33190 X-Source-Auth: tom+tromey.com X-Email-Count: 19 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3018.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> Test-case gdb.dwarf2/pr13961.exp contains: Tom> ... Tom> <1><25>: Abbrev Number: 8 (DW_TAG_class_type) Tom> <26> DW_AT_specification: <0x2a> Tom> <1><2a>: Abbrev Number: 2 (DW_TAG_class_type) Tom> <2b> DW_AT_name : foo Tom> <2f> DW_AT_byte_size : 4 Tom> <30> DW_AT_decl_file : 1 Tom> <31> DW_AT_decl_line : 1 Tom> <32> DW_AT_sibling : <0x44> It took me a while to understand the problem here, but I get it now. Thanks for doing this. Approved-By: Tom Tromey BTW this is maybe my least favorite part of DWARF, though the competition is pretty tough. Tom