From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by sourceware.org (Postfix) with ESMTPS id 6A6E63858000 for ; Wed, 2 Aug 2023 15:10:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6A6E63858000 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd2e.google.com with SMTP id ca18e2360f4ac-790b080f2a0so106299139f.3 for ; Wed, 02 Aug 2023 08:10:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1690989025; x=1691593825; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=qpVUTCYRDNX1ncTIbgPYVnawvtqPRJA7X/7G0/JBYJY=; b=K5i6Lb7hX07sNs9DXXIC7x/y3hCPVp7RmXn1U78aQIs4w03HjPCboCv1QLRXzRQVkI uWxOCXVaG196V1w0nHCvK1dCI6zzjFuR002tXkq5Ux2eoy7Z0sJOEbSvSRQey3zfW1lM SZEQjsT+Yix+IjWwYmpLUGmswXui+PyzuF736h6Gob9Mw83J5nFphfgbVjHePi5dQzFE tnmzLDD0gWYhefTKc/qwjm7uBISVeIvbRDGguAFGIkntl1ABxx9nnqLC2jAwAi/lVU+8 nrHqUUC4T0cy0N/rcVihwFMcJEgrn0bROJs6X4VfFNSAwH3nbf/Wr0LX02s4d59TWQFj mmxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690989025; x=1691593825; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qpVUTCYRDNX1ncTIbgPYVnawvtqPRJA7X/7G0/JBYJY=; b=VjUdSZyXoM5kCxF+QwTjU/LNLgIgmQ5UXPpZjvUYw6P0E9fcC9YRQuv7zc8dbqUvv0 bZ3dGlzG6Sh74sgkfhX5LHSacRBG14r/KLSiYJk8u5mjJn6J00h9nQePqNgOIFdJz96v Rk52TegudUj9JISFOo3IvbjrZKvJMYkbUKLmJHCCHh8VFG2BtNzCwOzZIgFlCt4lMi5J q6jNlMb1sCzYYb6daXhjgezxQIR6QwDhllSuFzV1zhOHtyFrrmV4Wgbj4jNfmpEZqPic 1Uz93RbXjNb58uTXMGolMUB7aMUpV5bkq+G2JvBj7XR2ZGiXJAS12CkvrI5QboIhBv7A FVxw== X-Gm-Message-State: ABy/qLYwY3ixhOJZQ61wpx82fJyB6cujixSCZmgCzpo1C7xxT+cIyfK6 vDijJUAujWHhSVZpHrviLa8+OQ== X-Google-Smtp-Source: APBJJlEB+YmAc9AhmYItdQautwZg5ZsBU8W3fyNZk7r5yNpprVqdAdV+MEhZeyAQi2WX2WfMOxT4rw== X-Received: by 2002:a05:6e02:2168:b0:346:7d1d:f97a with SMTP id s8-20020a056e02216800b003467d1df97amr18256444ilv.10.1690989025089; Wed, 02 Aug 2023 08:10:25 -0700 (PDT) Received: from murgatroyd (75-166-148-59.hlrn.qwest.net. [75.166.148.59]) by smtp.gmail.com with ESMTPSA id y3-20020a02c003000000b0042bb1779c18sm4365521jai.151.2023.08.02.08.10.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 08:10:24 -0700 (PDT) From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , Tom Tromey via Gdb-patches Subject: Re: [PATCH] Fix bug in fixed-point handling References: <20230719152442.67508-1-tromey@adacore.com> <87zg3cf33d.fsf@tromey.com> <1f4e795f-32c2-321d-d7f9-62a51437f513@suse.de> <87v8dyg79g.fsf@tromey.com> <5d7c9731-5c3c-5b07-17a3-d5f2eb2de7f4@suse.de> X-Attribution: Tom Date: Wed, 02 Aug 2023 09:10:23 -0600 In-Reply-To: <5d7c9731-5c3c-5b07-17a3-d5f2eb2de7f4@suse.de> (Tom de Vries's message of "Wed, 2 Aug 2023 02:02:36 +0200") Message-ID: <87il9xfpk0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> Yes, the test-cases passes for gcc 10, 11 and 12, and fails for gcc 7, Tom> 8 and 9. >> I'm wondering if the appended is enough or if it should be conditional >> on gcc 10 specifically. >> Tom> With the patch applied, it passes for all the above. Would you mind trying the appended? It tightens the test to make it specific to the "all" scenario and to be skipped only for GCC < 10. thanks, Tom diff --git a/gdb/testsuite/gdb.ada/fixed_points.exp b/gdb/testsuite/gdb.ada/fixed_points.exp index 2edc63f4071..05e86b9d0ed 100644 --- a/gdb/testsuite/gdb.ada/fixed_points.exp +++ b/gdb/testsuite/gdb.ada/fixed_points.exp @@ -92,6 +92,9 @@ foreach_with_prefix scenario {all minimal} { gdb_test "print fp5_var" " = 3e-19" } - gdb_test "p Float(Another_Fixed) = Float(Another_Delta * 5)" "true" \ - "value of another_fixed" + # This failed before GCC 10. + if {$scenario == "all" && [test_compiler_info {gcc-10-*}]} { + gdb_test "p Float(Another_Fixed) = Float(Another_Delta * 5)" "true" \ + "value of another_fixed" + } }