From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by sourceware.org (Postfix) with ESMTPS id C0A953858D1E for ; Mon, 26 Jun 2023 15:08:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C0A953858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd32.google.com with SMTP id ca18e2360f4ac-77e3267477cso182535239f.2 for ; Mon, 26 Jun 2023 08:08:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1687792079; x=1690384079; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=YADkyu1QBT2HYnYYG9Uay26I4ibb9AevnNrWkSxAWk8=; b=lX+KyDbfXOCiiOF1uZGgZSCNsgT8Y5cEvf0TYJ3j+tvtRa5Du9dIxj3Mz7PtFwpJmN fz1Bq/VZulsFCZfTOS5iMedI8kWrkwtzrFPF8PnqN+gY3kpnRMZLgWsM7cRaL8mC8wV8 9ODTrW+RUPcwQMTFqrVvLCnxBkUEW9e/GnxmItEiivAoLqncoLQDaGb5JjBXF3eEeg91 yoQQqZI7YRL5Ck2YD29gCJjS4Fatg0G7M8qnYuIyXOVAy4jsZ3s7+sJnQk9+IWKX/xnk ikdd6MXWfiZ32Y6W+9wpJUYVcholcaTR0pDsBEfRAP6ZKIlsmt3pnj3LPyhvme+HICjR x2Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687792079; x=1690384079; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YADkyu1QBT2HYnYYG9Uay26I4ibb9AevnNrWkSxAWk8=; b=AVkxRdAjp9ybUoBHzVtsxFDOS3BS7Y9/32FGB6LH/8jWJFuuqNZzjqDtKw3lJl/I6t SHhjv5c/yaEEP04J4instGua+IOYi3qk/dHVOcdIoPlfBBu0kaqZcMijg41DPYwrPq8D iqQeNYKDmn3ww4f+yu9FtlDpdV+Jc38vyg+va4GDVJRqYmNi+HdKEWZpf3y0wVaJCBXL WiebMrCbatx3raZHT1nTYJ/uOvPMnuSccpVjD3/tX92syyRoMYkp3AmeR8Yi4bp8eVdI TmLs8aXNR4+fWmBsAbRl3Xe2Nwl8oobCrN2DelvEI4prpLIzJwAEGl8UFp3hec1KKwCG likg== X-Gm-Message-State: AC+VfDw1XKWJVgVL7kMXGpxGECkIoE13vNPOUVN8MOMysSYZiqvrQC4N JBJfcy7gkpnzky8T/3SDT1EI1dDsZ9B4LGyKFqteTA== X-Google-Smtp-Source: ACHHUZ6a5R4emVgJBKwMHd6+fPOR4DnVr1OOZUsg9+7kCLQfr/MsA2Fcxuew+gjzdGDSHiM5DPeGMQ== X-Received: by 2002:a5e:8f07:0:b0:783:5e20:768d with SMTP id c7-20020a5e8f07000000b007835e20768dmr2447331iok.18.1687792079582; Mon, 26 Jun 2023 08:07:59 -0700 (PDT) Received: from murgatroyd (71-211-136-248.hlrn.qwest.net. [71.211.136.248]) by smtp.gmail.com with ESMTPSA id cg16-20020a056602255000b0078335414ddesm2235449iob.26.2023.06.26.08.07.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 08:07:59 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH v2 0/7] Reimplement DAP backtrace using frame filters References: <20230614-dap-frame-decor-v2-0-10628dfa6b60@adacore.com> X-Attribution: Tom Date: Mon, 26 Jun 2023 09:07:58 -0600 In-Reply-To: <20230614-dap-frame-decor-v2-0-10628dfa6b60@adacore.com> (Tom Tromey via Gdb-patches's message of "Thu, 22 Jun 2023 10:19:26 -0600") Message-ID: <87ilbaxnw1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> - Removed is_constant check from FrameVars This particular change caused a regression in the relatively new DAP "scopes" test, because that test has: static int scalar = 23; ... which is not used at all. This causes GCC to emit it as a constant. Now, I tend to think this change is a good one, because I think including enumeration constants in the locals output is not very useful, and because the above scenario isn't one that is likely to happen in real code. Another solution might be to find a way to eliminate enumeration constants from the output without affecting other local constants. Meanwhile, locally I've updated the scopes test to use the variable in question. But, do let me know what you think. It would be convenient if I could land my remaining DAP patches. Tom